fix: replace adhak_bindi (u0A01) with bindi (u0A02)#1922
Open
BalkiratS wants to merge 2 commits into
Open
Conversation
Member
|
This is incorrect 
Please read the Sant Lipi readme for more info. |
Member
Member
|
So it should be 0A01 -> 0A02 + FE00 Though idk why I chose VS1 here. I can't remember the reasoning. However this will look like a normally formed sihari + bindi following without Sant Lipi font. And then, where supported, it will show up as a bindi BEFORE the sihari. Same as your PDF shows. |
Contributor
Author
|
@bhajneet Added the commit with VS1 variation. |
Member
|
I'm really confused here. I'll have to pull this myself and compare strings with some utilities. The lines I'm testing are not working in Sant Lipi: https://shabados.github.io/SantLipi/qa/test/db-bindi-before-bihari.html |
BalkiratS
force-pushed
the
adhak_bindi_fix
branch
from
db47c97 to
344721d
Compare
Member
|
Can you share the shell script? I can just apply it and push it up and attribute the changes to you |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR normalizes 28 occurrences of the Gurmukhi adhak bindi character (ਁ, U+0A01) to the bindi character (ਂ, U+0A02) across 27 line files in collections/lines/.
The adhak bindi (ਁ) appears in only these 27 primary data fields out of ~141k line files in the database. After cross-referencing each line against two independent printed sources of Sri Guru Granth Sahib, the character appears as a standard bindi (ਂ) in both — suggesting the adhak bindi in the database is most likely an artifact of digitization rather than an intentional editorial distinction.
A full line-by-line audit with screenshots from both sources is attached:
Adhak_bindi_Audit.pdf