Fix canvas context state leakage in neon and render pipeline#120
Closed
serzel wants to merge 2 commits into
Closed
Fix canvas context state leakage in neon and render pipeline#120serzel wants to merge 2 commits into
serzel wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
shadowBlur,shadowColor,globalAlpha, or alteredglobalCompositeOperation.CanvasRenderingContext2D.Description
src/ui/neon.jsto wrap all drawing passes withwithIsolatedContext(ctx, ...)and addedresetGlowState(ctx)to explicitly normalizeglobalAlpha,globalCompositeOperation,shadowColor, andshadowBlurbefore use and on exit.intensityusage to safe bounds and removed reliance on*=style operations forglobalAlphaacross neon strokes.src/engine/Game.jsrender pipeline into isolated stages:#drawGame(),#drawParticles(), and#drawShots()that each usectx.save()/ctx.restore()withtry/finallyand explicitly reset glow-sensitive state after each stage.drawHUD()body in protectedsave()/restore()blocks with explicit state cleanup insrc/ui/HUD.jsto prevent HUD or neon draws leaking into subsequent profiler/overlay passes.Testing
node --check src/ui/neon.js && node --check src/engine/Game.js && node --check src/ui/HUD.js, which completed successfully.net::ERR_EMPTY_RESPONSE(visual validation not captured).Codex Task