Skip to content

Update react.js#3

Open
yarinkos wants to merge 1 commit into
serenadeai:masterfrom
yarinkos:master
Open

Update react.js#3
yarinkos wants to merge 1 commit into
serenadeai:masterfrom
yarinkos:master

Conversation

@yarinkos

@yarinkos yarinkos commented May 9, 2021

Copy link
Copy Markdown

Adding function with value return

@yarinkos

yarinkos commented May 9, 2021

Copy link
Copy Markdown
Author

@tmacwill , is this addition look fine ?

@tmacwill

Copy link
Copy Markdown
Member

apologies for the delayed response! it looks like this has two <%cursor%> elements—I think you only want one?

@yarinkos

yarinkos commented Jun 8, 2021

Copy link
Copy Markdown
Author

I think more about bootstrap functional component like, with the argument as a default return value :
const Headline = ({ value }) => { return {value}; };
But you don't have to accept it,maybe this one is too simple

@ryanpeach ryanpeach left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and return value in this snippet seems redundant as value is not a templated variable. Also it's a little long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants