Skip to content

fix moible deploy#2173

Merged
transphorm merged 1 commit into
devfrom
fix/mobile-deploy-2_9_24
Jun 13, 2026
Merged

fix moible deploy#2173
transphorm merged 1 commit into
devfrom
fix/mobile-deploy-2_9_24

Conversation

@transphorm

@transphorm transphorm commented Jun 13, 2026

Copy link
Copy Markdown
Member

Summary

Test plan


Native code checklist

Run each command and check the box only after it passes. Paste failures into the Test plan.

  • yarn lint && yarn types pass
  • Bridge contract tests pass: cd app && yarn jest:run and yarn workspace @selfxyz/rn-sdk-test-app test
  • If packages/mobile-sdk-alpha touched: cd packages/mobile-sdk-alpha && yarn test && yarn types pass
  • Diff of .kt/.swift reviewed — no business logic added (only hardware/OS access; logic lives in TypeScript)
  • NativeModules bridge contract (method names, payload keys, error codes) unchanged, or the change is intentional and described in the summary

Cannot be verified by an agent — flag for human QA:

  • Native builds (app + RN test app, iOS + Android) — relying on CI, or needs a human local build
  • On-device smoke test of the affected flow (e.g. NFC passport read, MRZ camera scan) — needs human, or N/A if no runtime behavior changed

Summary by CodeRabbit

Release Notes

No user-facing changes in this release. This update addresses internal build workflow configuration to enhance build process visibility during development and deployment cycles.

  • Chores
    • Updated mobile app deployment workflow configuration.

@vercel

vercel Bot commented Jun 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
self-webview-app Ignored Ignored Jun 13, 2026 4:05am

Request Review

@transphorm transphorm merged commit d8ea78b into dev Jun 13, 2026
14 of 19 checks passed
@transphorm transphorm deleted the fix/mobile-deploy-2_9_24 branch June 13, 2026 04:05
@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 81d8591f-2603-4b87-b68e-31ff5423dd80

📥 Commits

Reviewing files that changed from the base of the PR and between a0752aa and 8dd21e4.

📒 Files selected for processing (1)
  • .github/workflows/mobile-deploy.yml

📝 Walkthrough

Walkthrough

The mobile deployment workflow removes the --silent flag from dependency build steps for both iOS and Android platforms. Both changes affect the same command, making build output visible during the dependency installation phase instead of suppressing it.

Changes

Build step verbosity

Layer / File(s) Summary
Dependency build step verbosity
.github/workflows/mobile-deploy.yml
The pnpm --filter @selfxyz/mobile-app run build:deps command in both the iOS and Android build steps no longer suppresses output with --silent, making dependency build logs visible.

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/mobile-deploy-2_9_24

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps

greptile-apps Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Removes the --silent flag from the pnpm --filter @selfxyz/mobile-app run build:deps command in both the iOS and Android CI deploy jobs. This makes dependency build output visible in CI logs, which aids debugging when the step fails.

  • iOS job (line 640): --silent removed from Build Dependencies (iOS) step.
  • Android job (line 1110): --silent removed from Build Dependencies (Android) step.

Confidence Score: 5/5

Safe to merge — the change only removes a logging flag and does not affect build logic, secrets handling, or job control flow.

Both hunks are identical one-word removals of --silent from the pnpm invocation. The flag only controls whether pnpm suppresses its own stdout/stderr; removing it exposes build output in CI logs without changing what is built or how errors propagate.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/mobile-deploy.yml Removes --silent flag from the pnpm build:deps step in both the iOS and Android deploy jobs, making dependency build output visible in CI logs.

Sequence Diagram

sequenceDiagram
    participant GH as GitHub Actions
    participant pnpm as pnpm
    participant Script as build:deps script

    GH->>pnpm: pnpm run build:deps
    pnpm->>Script: execute build script
    alt Build succeeds
        Script-->>pnpm: exit 0
        pnpm-->>GH: Dependencies built successfully
    else Build fails
        Script-->>pnpm: exit non-zero
        pnpm-->>GH: Dependency build failed
    end
Loading

Reviews (1): Last reviewed commit: "fix moible deploy" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant