Extract 18 inline route handlers from registerReleaseRoutes()#781
Merged
Merged
Conversation
…~40 lines) Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
registerReleaseRoutes()inapps/server/src/routes/release.tsinto standalone named functionsgetReleaseStreamClientId,emitInfoProgress) to module-level functionsWhat qualifies as tech debt
All business logic was defined inline within one 714-line function body. This made it hard to navigate, test, or understand individual route handlers in isolation.
Next up
The next debt-collector run will tackle: extracting sub-functions from the 233-line
shutdown()method inapps/server/src/jobs/service.ts.Test plan
pnpm run check— TypeScript cleanpnpm run test— 200/200 unit tests passpnpm run test:e2e— 122/123 pass (1 pre-existing flake in split-pane.spec.ts)🤖 Generated with Claude Code