Extract FileTree and DiffPane from changes-tab.tsx (940 → 358 lines)#780
Merged
Merged
Conversation
…9 lines) Splits the oversized changes-tab.tsx into three focused files: - changes-file-tree.tsx (231 lines): FileTree sidebar with tree building/collapsing logic - changes-diff-section.tsx (371 lines): DiffPane, FileDiffSection, and FileDiffContent - changes-tab.tsx (358 lines): ChangesTab orchestrator with state management Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
changes-file-tree.tsx(231 lines)changes-diff-section.tsx(371 lines)changes-tab.tsxnow contains only the ChangesTab orchestrator component (358 lines, down from 940)This is a pure structural refactoring — no behavior, UI, or rendering changes. All three pieces were already logically independent within the original file.
New file structure
Next run
Queued:
notification-settings.tsx(646 lines) — extract setting sections into subcomponents.Test plan
pnpm run finalize:web— type check + production build passespnpm run test:e2e— 122/123 passed; 1 pre-existing flake (split-pane unsplit timeout)🤖 Generated with Claude Code