Fix monitor unhandled rejection and add agent-lifecycle-runtime tests#747
Merged
Merged
Conversation
Remove re-throw in job monitor catch handler when a run disappears from the DB — the warning is already logged and the re-throw creates an unhandled rejection since nobody awaits the monitor at that point. Add 28 unit tests for createAgentLifecycleRuntime covering archive dedup guard, reconcile loop idempotency, archive resume, activity monitor integration, and waitForActiveArchives timeout. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jobs-webhook-route.test.tssuite and was also observed in CI.createAgentLifecycleRuntimecovering archive dedup guard, reconcile loop idempotency, archive resume from reconciliation, activity monitor integration, andwaitForActiveArchivestimeout behavior.Test plan
pnpm run check— type checking passespnpm run test— 2264 tests pass, 0 errors (up from 2236)pnpm run test:e2e— 178 passed, 12 skipped (tmux-dependent, expected)jobs-webhook-route.test.tsno longer produces unhandled rejections🤖 Generated with Claude Code