Fix review feedback UI: overflow, text wrapping, and visual polish#746
Merged
Conversation
Address several UX issues in inline diff annotations and reviews sidebar: - Fix InlineCommentForm overflow in split diff view by removing explicit width from stickyAnnotationStyle (keep maxWidth as ceiling) - Eliminate horizontal scroll from annotation right margins (mx-3 → ml-3) - Make only annotation headers clickable for expand/collapse (not body) - Add green accent + checkmark styling for resolution blocks - Add break-words to all annotation text elements for long string handling - Replace MessageCircle with hollow Circle for open feedback items - Increase media sidebar width from 360px to 400px - Add overflow-wrap:anywhere to inline code in markdown - Align resolution block condition and label between sidebar and diff view Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
widthfromstickyAnnotationStyle, keeping onlymaxWidthas a ceiling so annotations fill their parent cell naturallymx-3→ml-3)break-wordsto all annotation text elements (including draft comments) for long string handlingMessageCirclewith hollowCirclefor open feedback items in reviews sidebaroverflow-wrap: anywhereto inline code in markdown componentitem.resolutiongate, includes resolution type)Test plan
pnpm run check— type checking passespnpm run finalize:web— production build passespnpm run test:e2e— 172 passed, 12 skipped (terminal-live)