Skip to content

Add MCP tools for review feedback resolution#741

Merged
selfcontained merged 4 commits into
mainfrom
add-review-mcp-tools-2
Jul 9, 2026
Merged

Add MCP tools for review feedback resolution#741
selfcontained merged 4 commits into
mainfrom
add-review-mcp-tools-2

Conversation

@selfcontained

Copy link
Copy Markdown
Owner

Summary

  • Adds dispatch_resolve_review_feedback MCP tool — agents can resolve human review feedback items as fixed, ignored, or wont_fix, with optional note. Parent review status auto-recomputes.
  • Adds dispatch_add_review_message MCP tool — agents can reply to review feedback threads (e.g. ask clarifying questions before resolving).
  • Full MCP plumbing: callback types on McpRequestContext, handler implementations in mcp-review-handlers.ts, zod-schema tool registrations in persona-interaction-tools.ts, wiring in mcp.ts and server.ts.

Test plan

  • Server type check passes (pnpm --filter @dispatch/server check)
  • Full type check passes (pnpm run check)
  • Unit tests pass (pnpm run test)
  • E2E tests (blocked by pre-existing react-diff-view install issue in worktrees — passes once pnpm install runs)

🤖 Generated with Claude Code

selfcontained and others added 4 commits July 9, 2026 10:32
Adds dispatch_resolve_review_feedback and dispatch_add_review_message
MCP tools so agents can resolve human review feedback items and reply
to review threads. Wired through the full MCP plumbing: callback types,
handlers, tool registrations, and route/server wiring.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
Tests resolveReviewFeedback and addReviewThreadMessage: success paths,
not-found errors, default values, and SSE event publishing.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
Job agents already have persona review tools but were missing the new
dispatch_resolve_review_feedback and dispatch_add_review_message tools.
Added to JOB_TOOLS and extended the integration test assertion.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
When a human review is submitted, the tmux injection now tells the
agent how to work through feedback: reply with questions, resolve
items with the MCP tools, and include notes when dismissing.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@selfcontained
selfcontained merged commit 5085c40 into main Jul 9, 2026
1 check passed
@selfcontained
selfcontained deleted the add-review-mcp-tools-2 branch July 9, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant