Refactor createAgent(): extract input prep and DB insert#740
Merged
Conversation
Extract prepareCreateInputs() and insertAgentRecord() from the 206-line createAgent() method. The main method now reads as a clear sequence of steps (prepare → insert → notify → seed media → launch) while the normalization and DB logic live in focused private methods. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prepareCreateInputs()fromcreateAgent()— moves ~94 lines of input normalization (type defaults, full-access args, ref name validation, worktree params, CLI session ID) into a focused private method returning a typedPreparedCreateInputsobject.insertAgentRecord()— moves the 30-line DB INSERT into its own method, separating persistence from orchestration.createAgent()drops from 206 lines to ~82 lines and reads as a clear sequence: prepare → insert → notify → seed media → launch.This is tech debt cleanup — no behavior change.
Next up: Extract
UnifiedDiffViewcomponent fromchanges-tab.tsx(1127-line file).Test plan
pnpm run check— TypeScript type checking passespnpm run test— all 188 unit tests passpnpm run test:e2e— all 172 E2E tests pass🤖 Generated with Claude Code