Extract utility functions and GitHub helpers from release-runtime.ts#732
Merged
Merged
Conversation
…732) Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createReleaseRuntime()closure inrelease-runtime.tsinto a newrelease-helpers.tsmodule.parseGhJson,compareSemver,currentReleaseBinaryGlob,defaultServiceRestartCommand,getGitHubRepo,checkIsAdmin,fetchReleaseMetadata, plus theRunCommandandGitHubReleaseMetadatatypes.release-runtime.tsdrops from 886 to 746 lines. The public API surface is unchanged — callers are unaffected.Why this qualifies as tech debt
The
createReleaseRuntime()function was a single 737-line closure containing everything from pure string utilities to GitHub CLI wrappers to deploy orchestration. The pure/GitHub-only functions had no dependency on the closure state and were unnecessarily entangled with deploy/streaming logic. Extracting them improves readability and makes them independently testable.What's next
The backlog top item is extracting
createAgent()inapps/server/src/agents/manager.ts.🤖 Generated with Claude Code