Add Phase 3a: review submission, feedback sidebar, and inline annotations#729
Closed
selfcontained wants to merge 1 commit into
Closed
Add Phase 3a: review submission, feedback sidebar, and inline annotations#729selfcontained wants to merge 1 commit into
selfcontained wants to merge 1 commit into
Conversation
…ions Introduces a structured review system for agent diffs. Humans can enter review mode in the Changes tab, accumulate draft comments anchored to code lines, and submit them as a batch review. On submission the review is persisted (reviews + review_feedback_items + review_thread_messages tables), the assigned agent receives a tmux notification, and an SSE event pushes a live update to all connected clients. New "Reviews" tab in the right sidebar shows all reviews for the focused agent with expandable cards showing feedback items, status chips, resolution progress bars, and thread messages. Inline annotations in the diff view render persisted feedback items at their line ranges as collapsible widgets with status, reviewer badge, and the initial comment. Resolved items appear muted and collapsed by default. Backend: 3 new tables (migration 0029), data layer with transaction- based creation, 4 API endpoints (POST/GET reviews, GET review detail, GET all feedback items), SSE event types for live updates. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New files
apps/server/src/db/migrations/0029_reviews.sql-- 3 tables: reviews, review_feedback_items, review_thread_messagesapps/server/src/agents/reviews.ts-- data layer (create, list, get review, list all feedback items)apps/server/src/routes/agents/review-routes.ts-- 4 API endpoints (POST/GET reviews, GET detail, GET feedback)apps/web/src/components/app/reviews-tab-content.tsx-- sidebar Reviews tab UIapps/web/src/hooks/use-agent-reviews.ts-- React Query hooks for reviews and feedbackModified files
Test plan
pnpm run check(TypeScript) passespnpm run finalize:web(production build) passespnpm run test(188 unit tests pass, including migration-repair test)pnpm run test:e2e(172 E2E tests pass)🤖 Generated with Claude Code