Skip to content

Keep quick phrase send label stable #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
selfcontained merged 1 commit into from
Jul 1, 2026
Merged

Keep quick phrase send label stable #714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/web/src/components/app/quick-phrases/fill-variables-dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ export function FillVariablesDialog({
</Button>
<InjectSplitButton
disabled={requiredMissing || isPending}
isPending={isPending}
onInject={onInject}
/>
</div>
Expand Down
5 changes: 2 additions & 3 deletions apps/web/src/components/app/quick-phrases/inject-split-button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,17 @@ import { cn } from "@/lib/utils";

export function InjectSplitButton({
disabled,
isPending,
onInject,
size = "default",
insidePopover = false,
}: {
disabled: boolean;
isPending: boolean;
onInject: (submit: boolean) => void;
size?: "sm" | "default";
insidePopover?: boolean;
}) {
const isSm = size === "sm";
const label = isSm ? "Send" : "Send & Submit";

return (
<div className={cn("flex items-stretch", isSm && "min-w-[5.5rem]")}>
Expand All @@ -41,7 +40,7 @@ export function InjectSplitButton({
}
>
{isSm ? <Play className="h-2.5 w-2.5 fill-current" /> : null}
{isPending ? "Sending…" : isSm ? "Send" : "Send & Submit"}
{label}
</Button>
<DropdownMenu>
<DropdownMenuTrigger asChild>
Expand Down
1 change: 0 additions & 1 deletion apps/web/src/components/app/quick-phrases/phrase-row.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ export function PhraseRow({
) : (
<InjectSplitButton
disabled={isPending}
isPending={isPending}
onInject={onInject}
size="sm"
insidePopover
Expand Down