Add diff-file-rules tests, fix terminal drag-drop flake#692
Merged
Conversation
38 new unit tests for shouldExcludePath, looksBinary, countLines, and readUntrackedFile covering lock file exclusion, binary detection boundaries, line counting edge cases, path traversal blocking, size limits, and symlink rejection. Fix race condition in terminal-drag-drop E2E tests where drag/drop events fired before the terminal WebSocket connected, causing "Connect to an agent before uploading files" errors under parallel load. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
diff-file-rules.tsutility functions (shouldExcludePath,looksBinary,countLines,readUntrackedFile) covering lock file exclusion, binary detection boundaries, line counting edge cases, path traversal blocking, size limits, and symlink rejectionTest plan
pnpm run checkpassespnpm run testpasses (1993 server + 180 web tests)pnpm run test:e2epasses (171/171, 12 skipped tmux tests)🤖 Generated with Claude Code