Fix sidebar/quick-phrases toggles occluded in empty state (#687)#689
Closed
niiyeboah wants to merge 2 commits into
Closed
Fix sidebar/quick-phrases toggles occluded in empty state (#687)#689niiyeboah wants to merge 2 commits into
niiyeboah wants to merge 2 commits into
Conversation
The center-pane tab-bar backdrop (full-width, opaque `bg-background`, `z-10`) shares a z-index with the corner toggle controls and, being later in DOM order, painted over them. Because the backdrop is `pointer-events-none`, hit-testing passed through to the buttons — so they stayed clickable and keyboard-reachable, but were visually hidden. In the empty / no-focused-agent state this left the user with no visible way to reopen a collapsed sidebar (regression from the #685 Changes-tab rework). Raise the left (Open sidebar / quick-phrases) and right (media) corner toggle controls to `z-20` so they always paint above the tab-bar backdrop, in both the empty and focused-agent states. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
…687) - Add inline comments noting the z-20 corner controls must paint above the opaque z-10 tab-bar backdrop, so a future z-index cleanup doesn't revert the fix (architecture-review). - Widen the tab-bar backdrop from px-16 to px-24 so the centered tab bar stays clear of the two-button left toggle group (~80px), preventing the now-z-20 controls from overlapping the tab bar in the focused-agent + collapsed-sidebar state on a narrow pane (frontend-ux-review). Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #687 — after the #685 Changes-tab rework, the center pane offered no visible way to reopen a collapsed sidebar in the empty / no-focused-agent state. The user appeared stuck unless they knew the keyboard shortcut.
Root cause
The investigation found the real cause is not the
hasActiveAgentgating hypothesized in the issue (that affects only the media toggle, which is intentionally per-agent). The actual culprit:The center-pane tab-bar backdrop (
agents-view.tsx, the full-width, opaquebg-background,z-10strip behind the centeredCenterPaneTabBar) shares a z-index with the corner toggle controls and, being later in DOM order, paints over them. Because the backdrop ispointer-events-none, hit-testing passes through to the buttons — so they stay clickable and keyboard-reachable, but are visually hidden. This is why the toggles appear "missing" yet the hotkeys still work, and why it's a regression from the #685 layout rework.This was confirmed empirically:
document.elementFromPoint()returned the toggle's SVG icon (topmost, correct color, opacity 1), yet the rendered screenshot showed the corners blank — the signature of apointer-events-noneopaque overlay occluding paint without affecting hit-testing.Fix
Raise the left (Open-sidebar / quick-phrases) and right (media) corner toggle controls from
z-10toz-20so they always paint above the tab-bar backdrop — in both the empty and focused-agent states. Two-class CSS change; no behavioral/state changes.Validation
pnpm --filter @dispatch/server check✓ andpnpm --filter @dispatch/web check✓pnpm run finalize:web(web production build) ✓Notes / out of scope
tsc -p tsconfig.scripts.jsononbin/embed-assisted-update.ts) and the Playwright e2e harness (Cannot find package 'pg') both fail on this machine for pre-existing, environment-level reasons unrelated to this change.allowBuilds(esbuild/sharp) migrated intopnpm-workspace.yamlto rundispatch-dev; that is intentionally not included here to keep this PR scoped to Sidebar toggle missing after Changes/diff update (#685) — no on-screen way to reopen sidebars in empty state #687.🤖 Generated with Claude Code