Unset TLS vars in dispatch-dev for plain HTTP dev servers#49
Merged
Conversation
The orphan session cleanup was killing any dispatch_agt_* tmux session that had no matching record in the current database. This caused dev server instances (running against isolated databases) to kill the production agent's tmux session on startup — because the dev DB was empty and had no record of that agent. Now we only kill sessions for agents in terminal states (stopped/error) that the database definitively knows about. Unknown sessions are left alone since they may belong to another server instance. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Dev server processes inherit TLS_CERT/TLS_KEY from the production environment via the agent's shell. This causes dev servers to serve HTTPS with self-signed certs that browsers refuse to connect to. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TLS_CERTandTLS_KEYbefore starting the API server indispatch-devTest plan
npm run check+npm testpass🤖 Generated with Claude Code