ci: parallelize the action steps when possible#3225
Open
M0NsTeRRR wants to merge 3 commits into
Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR reorganizes multiple GitHub Actions workflows so independent steps run in ChangesWorkflow step parallelization
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
seerr
 |
||||||||||||||||||||||||||||
| Project |
seerr
|
| Branch Review |
ci/parallel-step
|
| Run status |
|
| Run duration | 02m 19s |
| Commit |
|
| Committer | Ludovic Ortega |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
0
|
 |
0
|
 |
0
|
 |
33
|
| View all changes introduced in this branch ↗︎ | |
Signed-off-by: Ludovic Ortega <[email protected]>
M0NsTeRRR
force-pushed
the
ci/parallel-step
branch
from
1fd5a42 to
86d1149
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 7
🧹 Nitpick comments (2)
.github/workflows/pr-validation.yml (2)
161-288: 🎯 Functional Correctness | 🔵 Trivial | 💤 Low valueDrop the
parallel:wrapper here. The two branches are mutually exclusive (exit_code != '0'vs== '0'), so they can’t run concurrently and the wrapper only adds noise.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/pr-validation.yml around lines 161 - 288, Remove the unnecessary parallel wrapper around the two github-script branches in the workflow job. The “Label and comment on failure” and “Remove label on success” steps are already mutually exclusive via steps.check.outputs.exit_code, so they should be kept as direct sibling steps instead of being nested under parallel:. Update the workflow structure in the pr-validation job while preserving the existing conditions, labels, and comment logic in both branches.
34-110: 🎯 Functional Correctness | 🔵 Trivial | 💤 Low valueRemove the redundant
parallel:wrapper — the two branches are mutually exclusive, so only one can ever run and the wrapper adds no concurrency benefit.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/pr-validation.yml around lines 34 - 110, Remove the unnecessary parallel wrapper around the two actions/github-script branches in pr-validation workflow. The branches already depend on mutually exclusive conditions in the lint_pr_title step, so execute them directly as sibling steps instead of nesting under parallel, keeping the existing if checks and the comment update/delete logic in place.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 228-252: The parallel block in the workflow incorrectly runs
Commit timestamp alongside Checkout, but `ts` depends on the repository being
checked out before `git log -1 --pretty=%ct` executes. Move `Commit timestamp`
out of the `parallel` group so it runs after `Checkout`, while keeping `Set up
Docker Buildx` and both `docker/login-action` steps parallelized since they are
independent.
- Around line 191-202: The parallel block incorrectly groups the commit
timestamp step with Checkout even though Commit timestamp depends on the
repository being cloned first. Move the git log-based timestamp logic out of the
parallel group in .github/workflows/ci.yml and keep it sequential after
actions/checkout, while leaving Set up Docker Buildx as the independent step
that can stay parallelized. Use the Checkout and Commit timestamp step names to
locate the affected workflow section.
In @.github/workflows/helm.yml:
- Around line 30-48: The job setup in the helm workflow is using an unsupported
parallel: wrapper, which breaks actionlint and job execution. Remove the
parallel: nesting in the package-helm-chart, publish, and verify jobs and
restore those steps to a normal sequential steps list, matching the fix pattern
used for the corresponding release workflow jobs. Use the job names and step
blocks around Checkout, Install helm, Install Oras, and Login to GitHub
Container Registry to locate each affected section.
In @.github/workflows/lint-helm-charts.yml:
- Around line 30-58: The workflow job contains invalid step grouping and
indentation in the lint-helm-charts workflow. Remove the unsupported parallel:
wrappers around the Checkout/Set up Helm/Set up chart-testing and Ensure
documentation is updated/Run chart-testing (list-changed) steps, then make Run
chart-testing a properly indented sibling step under steps: so the chart-testing
flow remains a flat sequential list. Use the existing step names and the
list-changed step id to locate the affected block.
In @.github/workflows/preview.yml:
- Around line 35-56: The preview workflow uses an unsupported parallel: wrapper
around the build setup steps, which actionlint rejects. Remove the parallel:
block and keep the Checkout, Commit timestamp, Set up Docker Buildx, and Derive
preview version from tag entries as a normal sequential step list, matching the
same fix pattern used in release workflow setup blocks.
In @.github/workflows/renovate-helm-custom-hooks.yml:
- Around line 27-41: The workflow job currently wraps the setup actions under an
unsupported parallel block, which breaks validation; remove the parallel
grouping and restore these steps as normal sequential entries in the
renovate-helm-custom-hooks workflow. Keep the existing actions/checkout,
actions/create-github-app-token, and helm/chart-testing-action steps intact, but
place them directly under the job step list rather than under parallel.
- Around line 34-38: The GitHub App token step is using the wrong identifier in
the create-github-app-token action. Update the app-token configuration to use
the correct field name in the workflow, referencing
actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 and the
app-token step: either change client-id to app-id for the numeric value, or
replace it with the actual GitHub App Client ID string.
---
Nitpick comments:
In @.github/workflows/pr-validation.yml:
- Around line 161-288: Remove the unnecessary parallel wrapper around the two
github-script branches in the workflow job. The “Label and comment on failure”
and “Remove label on success” steps are already mutually exclusive via
steps.check.outputs.exit_code, so they should be kept as direct sibling steps
instead of being nested under parallel:. Update the workflow structure in the
pr-validation job while preserving the existing conditions, labels, and comment
logic in both branches.
- Around line 34-110: Remove the unnecessary parallel wrapper around the two
actions/github-script branches in pr-validation workflow. The branches already
depend on mutually exclusive conditions in the lint_pr_title step, so execute
them directly as sibling steps instead of nesting under parallel, keeping the
existing if checks and the comment update/delete logic in place.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: fe8e4df5-b81c-48b6-b290-6b7e60f42b5c
📒 Files selected for processing (15)
.github/workflows/ci.yml.github/workflows/codeql.yml.github/workflows/create-tag.yml.github/workflows/cypress.yml.github/workflows/detect-duplicate.yml.github/workflows/docs-deploy.yml.github/workflows/helm.yml.github/workflows/lint-helm-charts.yml.github/workflows/pr-validation.yml.github/workflows/preview.yml.github/workflows/rebuild-issue-index.yml.github/workflows/release.yml.github/workflows/renovate-helm-custom-hooks.yml.github/workflows/seerr-labeller.yml.github/workflows/test-docs.yml
Contributor
There was a problem hiding this comment.
Actionable comments posted: 7
♻️ Duplicate comments (4)
.github/workflows/ci.yml (2)
191-202: 🎯 Functional Correctness | 🔴 Critical | ⚡ Quick winInvalid
parallel:syntax, plus unresolved Checkout/git-log race flagged in a prior review.Two independent problems here:
- Same malformed
parallel:shape as above (actionlint error, Line 191).- Even once corrected to valid branch syntax,
Commit timestamp(git log -1 --pretty=%ct) still requiresCheckoutto complete first — putting it in the same parallel group risks failure or a staleSOURCE_DATE_EPOCHused later in the Docker build (Line 214). This was already raised in a previous review and remains unaddressed.🐛 Proposed fix — valid syntax + correct ordering
steps: - - parallel: - - name: Checkout - uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3 - with: - persist-credentials: false - - - name: Commit timestamp - id: ts - run: echo "TIMESTAMP=$(git log -1 --pretty=%ct)" >> "$GITHUB_OUTPUT" - - - name: Set up Docker Buildx - uses: docker/setup-buildx-action@d7f5e7f509e45cec5c76c4d5afdd7de93d0b3df5 # v4 + - name: Checkout + uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3 + with: + persist-credentials: false + + - name: Commit timestamp + id: ts + run: echo "TIMESTAMP=$(git log -1 --pretty=%ct)" >> "$GITHUB_OUTPUT" + + - name: Set up Docker Buildx + uses: docker/setup-buildx-action@d7f5e7f509e45cec5c76c4d5afdd7de93d0b3df5 # v4🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/ci.yml around lines 191 - 202, The workflow block under the parallel group is malformed and also places Commit timestamp in the same group as Checkout, which can race before the repository is available. Fix the invalid parallel syntax in the CI workflow, then ensure actions/checkout completes before the git log step that sets TIMESTAMP (the Commit timestamp step) by moving it out of the parallel branch or otherwise enforcing ordering; use the Checkout, Commit timestamp, and Set up Docker Buildx steps as the key anchors.Source: Linters/SAST tools
228-252: 🎯 Functional Correctness | 🔴 Critical | ⚡ Quick winSame invalid
parallel:syntax and Checkout/git-log race as thebuildjob (already flagged previously).Identical issue to Lines 191-202: malformed
parallel:block plusCommit timestampdepending onCheckoutcompleting first, which affectssteps.ts.outputs.TIMESTAMPused at Lines 265 and 277.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/ci.yml around lines 228 - 252, The CI job still uses the invalid parallel block and has the same Checkout/git-log ordering problem as the build job. Update this job’s parallel group so the step sequence is valid, and make sure Commit timestamp runs only after the Checkout step has completed and the repository is available. Keep the dependency explicit for the ts step since steps.ts.outputs.TIMESTAMP is consumed later in the job.Source: Linters/SAST tools
.github/workflows/renovate-helm-custom-hooks.yml (2)
27-41: 🎯 Functional Correctness | 🔴 Critical | ⚡ Quick winInvalid
parallel:step block — still unresolved from a prior review.Same malformed
parallel:shape flagged by actionlint (Line 27); a previous review already called this out and it remains unfixed.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/renovate-helm-custom-hooks.yml around lines 27 - 41, The workflow still contains an invalid parallel step shape in the Renovate Helm custom hooks job, so actionlint will keep failing. Update the job section around the existing Checkout code, create-github-app-token, and Set up chart-testing steps to remove the malformed parallel block and express the steps in the correct GitHub Actions structure using the relevant job/workflow step definitions. Make the change in the workflow YAML where these three actions are declared so the parser sees a valid steps layout.Source: Linters/SAST tools
34-38: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
client-id: 2138788still looks like a numeric App ID — unresolved from a prior review.A previous review flagged that
2138788appears to be a GitHub App ID, not a Client ID, so token creation viaclient-idwill likely fail. This is unchanged in the current code.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/renovate-helm-custom-hooks.yml around lines 34 - 38, The GitHub App token setup in the workflow still uses a numeric value for the create-github-app-token action’s client-id, which should be the App’s Client ID rather than the App ID. Update the app-token step to use the correct client-id value in the actions/create-github-app-token configuration, and verify the secret/reference used for the private key still matches this app.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 42-49: Remove the invalid parallel block from the GitHub Actions
workflow and keep the Pnpm Setup and Set up Node.js steps as normal sequential
steps in the CI job. The issue is in the workflow definition around the
pnpm/action-setup and actions/setup-node entries; if concurrency is needed, move
those actions into separate jobs or a matrix strategy instead of using parallel:
inside steps.
In @.github/workflows/codeql.yml:
- Around line 39-49: The CodeQL workflow uses an invalid parallel block, so the
job definition should be changed to a normal sequential step list. Update the
workflow around the Checkout and Initialize CodeQL entries in the codeql job so
actions/checkout runs first and github/codeql-action/init runs immediately after
it as separate standard steps, preserving the existing configuration while
removing parallel:.
In @.github/workflows/create-tag.yml:
- Around line 63-78: The create-tag workflow uses an invalid parallel wrapper,
so the job will not parse in GitHub Actions. Update the workflow by removing the
parallel block in create-tag.yml and flattening the Pnpm Setup, Set up Node.js,
and Configure git entries into normal sequential steps in the same job.
In @.github/workflows/release.yml:
- Around line 208-231: The release workflow currently uses a nested parallel
block under the job’s steps, which GitHub Actions will not parse. Update the job
in release.yml by replacing the parallel grouping with normal sequential steps,
or split the Checkout, Install Cosign, Install Trivy, and docker/login-action
steps into separate jobs if true concurrency is required.
- Around line 78-89: Remove the invalid parallel block in the release workflow
and make these steps run one after another in the job’s step list. Keep Checkout
before Commit timestamp so the git log command in the ts step can read the
checked-out repository, then continue with Set up Docker Buildx afterward.
- Around line 118-142: The Commit timestamp step is incorrectly inside the
parallel block even though it depends on Checkout having already fetched the
repo history. Move the ts step out of the parallel section in the release
workflow so it runs after actions/checkout completes, and keep using
steps.ts.outputs.TIMESTAMP only once the timestamp has been reliably set.
- Around line 278-299: The release workflow uses an invalid `parallel:` wrapper
around `Verify signatures` and `Verify attestations`, so GitHub Actions will not
parse this step block. In `.github/workflows/release.yml`, update the workflow
structure by removing `parallel:` and placing these as standard steps or
splitting them into separate jobs, keeping the existing `cosign verify` and
`cosign verify-attestation` commands intact within the `run` blocks.
---
Duplicate comments:
In @.github/workflows/ci.yml:
- Around line 191-202: The workflow block under the parallel group is malformed
and also places Commit timestamp in the same group as Checkout, which can race
before the repository is available. Fix the invalid parallel syntax in the CI
workflow, then ensure actions/checkout completes before the git log step that
sets TIMESTAMP (the Commit timestamp step) by moving it out of the parallel
branch or otherwise enforcing ordering; use the Checkout, Commit timestamp, and
Set up Docker Buildx steps as the key anchors.
- Around line 228-252: The CI job still uses the invalid parallel block and has
the same Checkout/git-log ordering problem as the build job. Update this job’s
parallel group so the step sequence is valid, and make sure Commit timestamp
runs only after the Checkout step has completed and the repository is available.
Keep the dependency explicit for the ts step since steps.ts.outputs.TIMESTAMP is
consumed later in the job.
In @.github/workflows/renovate-helm-custom-hooks.yml:
- Around line 27-41: The workflow still contains an invalid parallel step shape
in the Renovate Helm custom hooks job, so actionlint will keep failing. Update
the job section around the existing Checkout code, create-github-app-token, and
Set up chart-testing steps to remove the malformed parallel block and express
the steps in the correct GitHub Actions structure using the relevant
job/workflow step definitions. Make the change in the workflow YAML where these
three actions are declared so the parser sees a valid steps layout.
- Around line 34-38: The GitHub App token setup in the workflow still uses a
numeric value for the create-github-app-token action’s client-id, which should
be the App’s Client ID rather than the App ID. Update the app-token step to use
the correct client-id value in the actions/create-github-app-token
configuration, and verify the secret/reference used for the private key still
matches this app.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 30c80912-e079-4067-85a7-b6876fc81003
📒 Files selected for processing (15)
.github/workflows/ci.yml.github/workflows/codeql.yml.github/workflows/create-tag.yml.github/workflows/cypress.yml.github/workflows/detect-duplicate.yml.github/workflows/docs-deploy.yml.github/workflows/helm.yml.github/workflows/lint-helm-charts.yml.github/workflows/pr-validation.yml.github/workflows/preview.yml.github/workflows/rebuild-issue-index.yml.github/workflows/release.yml.github/workflows/renovate-helm-custom-hooks.yml.github/workflows/seerr-labeller.yml.github/workflows/test-docs.yml
Signed-off-by: Ludovic Ortega <[email protected]>
Signed-off-by: Ludovic Ortega <[email protected]>
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
.github/workflows/ci.yml (1)
228-253: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick winKeep the two
docker/login-actionsteps sequentialBoth steps write to the same
~/.docker/config.json, so running them in the sameparallel:block can clobber one registry’s auth and make the publish job fail intermittently.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/ci.yml around lines 228 - 253, The two docker/login-action steps are being run in parallel and can overwrite the shared Docker config, causing registry auth to be lost. Move the Docker Hub and GHCR login steps out of the parallel block so they execute sequentially in the ci workflow, keeping their auth writes ordered and stable..github/workflows/preview.yml (1)
82-117: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick winKeep the Docker logins sequential. Running
docker/login-actionfor Docker Hub and GHCR at the same time can race on~/.docker/config.jsonand drop one registry credential, which can make a later push fail intermittently.Checkout,Buildx, and version derivation can stay parallel.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/preview.yml around lines 82 - 117, The Docker Hub and GHCR authentication steps in the preview workflow are running in parallel and can overwrite the shared Docker config; update the job so the two docker/login-action steps execute sequentially, while keeping Checkout, Set up Docker Buildx, and Derive preview version from tag in the parallel group.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In @.github/workflows/ci.yml:
- Around line 228-253: The two docker/login-action steps are being run in
parallel and can overwrite the shared Docker config, causing registry auth to be
lost. Move the Docker Hub and GHCR login steps out of the parallel block so they
execute sequentially in the ci workflow, keeping their auth writes ordered and
stable.
In @.github/workflows/preview.yml:
- Around line 82-117: The Docker Hub and GHCR authentication steps in the
preview workflow are running in parallel and can overwrite the shared Docker
config; update the job so the two docker/login-action steps execute
sequentially, while keeping Checkout, Set up Docker Buildx, and Derive preview
version from tag in the parallel group.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b625762e-e6be-421e-a026-62dd0b71790d
📒 Files selected for processing (3)
.github/workflows/ci.yml.github/workflows/preview.yml.github/workflows/release.yml
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/release.yml
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
parallelize the action steps when possible
https://github.blog/changelog/2026-06-25-actions-steps-can-now-be-run-in-parallel/
This PR doesn’t add much optimization for most steps, since many of the parallel tasks like Docker login, GitHub Actions setup, or Node.js and pnpm installation are already fast. However, for some actions like CI the improvements are noticeable:
How Has This Been Tested?
Not tested
Screenshots / Logs (if applicable)
Checklist:
pnpm buildpnpm i18n:extractSummary by CodeRabbit
Summary by CodeRabbit