Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
muon.prot.pp.clrcrashes on the seurat flavor whenadata.Xis an old-style SciPy sparse matrix (csc_matrix/csr_matrix):For an
spmatrix,np.log1p(x).mean(axis=axis)returns anumpy.matrix, which has no.toarray()method, so the existing line fails. This affects common datasets whose ADT.Xis still anspmatrix(e.g.papalexi_2021).Fix
Compute the per-feature log-mean once and coerce it to a plain array depending on the container type:
csc_matrix/csr_matrix: use.Aandx.getnnz(axis=axis)np.diff(x.indptr)to avoid thegetnnzbehavior change (ENH: sparse.csr_array: keep axis functionality ingetnnz()scipy/scipy#19405)The
axistype hint is also tightened toLiteral[0, 1].Verification
Installed this branch and ran the pertpy
perturbation_efficacytutorial (which callsmu.prot.pp.clr(mdata["adt"], axis=1)onpapalexi_2021) end-to-end: all 32 code cells execute with no errors. CLR output on bothaxis=0andaxis=1is finite, non-negative, and preserves sparsity as expected for the seurat flavor.