Skip to content

fix(types): annotate pdb URL fallback list#255

Merged
lauraluebbert merged 1 commit into
scverse:devfrom
Qiaoli-Li-Res:fix/pdb-url-fallback-types
Jun 26, 2026
Merged

fix(types): annotate pdb URL fallback list#255
lauraluebbert merged 1 commit into
scverse:devfrom
Qiaoli-Li-Res:fix/pdb-url-fallback-types

Conversation

@Qiaoli-Li-Res

Copy link
Copy Markdown

Summary

  • Add an explicit type annotation for the PDB URL fallback list.
  • Fix the remaining mypy list item errors in gget_pdb.py.
  • No runtime behavior changes.

Validation

  • Ran pre-commit run mypy --files gget/gget_pdb.py.

Part of #216.

@codecov-commenter

codecov-commenter commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.44%. Comparing base (5cf607f) to head (db77647).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #255      +/-   ##
==========================================
+ Coverage   56.14%   56.44%   +0.30%     
==========================================
  Files          29       29              
  Lines        9244     9244              
==========================================
+ Hits         5190     5218      +28     
+ Misses       4054     4026      -28     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Qiaoli-Li-Res

Copy link
Copy Markdown
Author

The targeted mypy check passes locally with pre-commit run mypy --files gget/gget_pdb.py. The failing pytest cases are all in tests/test_opentargets.py, so they appear unrelated to this gget_pdb.py type-only change.

@lauraluebbert lauraluebbert merged commit 682d7c6 into scverse:dev Jun 26, 2026
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants