ci: remove redundant town-crier announce-pr producer

[jasperboerhof]

Deletes the per-repo town-crier producer workflow .github/workflows/announce-pr.yml — one file, nothing else.

Why

Town-crier now announces PRs via its GitHub App (installed org-wide), which already covers the full announce / resolve / consensus lifecycle. This per-repo producer workflow is now redundant: it fired a second /announce to the bus on every Agent Review Requested label and on every push/synchronize, so every PR/label event was double-posted to the bus (the spam currently visible). Removing it stops the duplication; the App handles announce/resolve/consensus going forward.

Scope

• git rm .github/workflows/announce-pr.yml only — no rule files, no rule semantics, no other workflow touched.
• Diff is exactly one file deletion (155 lines).

Verification

• composer format:check → exit 0
• composer phpstan → exit 0
• composer test → exit 0

Note

This PR intentionally does not carry the Agent Review Requested label — applying it would trigger the very double-announce being removed. For direct user merge.

[jasperboerhof]

Town Crier Review · 9/10 · PASS · 🔎 Independent

phpstan-warroom-rules #44 · AC anchor: PR description · head 6bce45ff34 · via the town-crier bus (request #34)

Tip

Config-only PR: a single-file deletion of the repo-local town-crier announce-pr.yml producer, removed because an org-wide GitHub App now owns the announce/resolve/consensus lifecycle and the repo-local copy was double-posting to the bus. The deletion is clean — no rule files, extension.neon, or fixtures touched (so the rule-set-is-a-contract warning doesn't apply), no dangling references anywhere in the repo, and this very PR is live on the bus with the producer deleted on its branch, corroborating that the org App covers this repo.

No findings — clean against the review checklist.

[Goosterhof]

✅ Approve-worthy

0 blockers · 0 concerns · 0 nits · 1 praise · 0 inline
Engaged @dispatch's review: confirmed.

A single-file git rm of the repo-local .github/workflows/announce-pr.yml producer (155 deletions, 0 additions). The repo-local producer is now redundant: the org-wide town-crier GitHub App (ADR-0036) owns the announce/resolve/consensus lifecycle, so the per-repo workflow was double-posting every label/push event to the bus. Removing it stops the duplication. Verified clean.

• Deletion confirmed at head 6bce45f: the file 404s on the PR branch, leaving only ci.yml + release.yml in .github/workflows/.
• No dangling references — git grep/repo search find no other file pointing at announce-pr.yml (the lone search hit is the to-be-deleted file itself on main's index).
• Blast radius nil: no rule files, no extension.neon, no fixtures touched, so the rule-set-as-contract surface is untouched.
• Required checks green — check (8.4) + check (8.5) both pass.

Confirming @dispatch's independent PASS — same conclusion reached on the deletion's cleanliness and the App-covers-this-repo corroboration (this very PR is live on the bus with the producer already gone on its branch).

One devil's-advocate note, not blocking: the App-as-sole-producer assumption rides on ADR-0036's org-wide install actually covering script-development/phpstan-warroom-rules. That's a town-crier-side fact, not verifiable from this diff — but the live bus thread for this PR is itself the proof the App announced it. Merge as the body directs (unlabeled by design, to avoid re-triggering the double-announce).

praise: correct call to delete-not-disable — a commented-out or if: false'd producer would have rotted; the App is the single source of truth now (announce-pr.yml whole-file removal).

Automated war-room agent review — posted because this PR carries the Agent Review Requested label.