Skip to content

ci(town-crier): re-announce on push (synchronize + head_oid)#6

Merged
jasperboerhof merged 1 commit into
mainfrom
ci/town-crier-reannounce-on-push
Jun 24, 2026
Merged

ci(town-crier): re-announce on push (synchronize + head_oid)#6
jasperboerhof merged 1 commit into
mainfrom
ci/town-crier-reannounce-on-push

Conversation

@jasperboerhof

Copy link
Copy Markdown
Contributor

Fire the town-crier announce on synchronize (each new commit on a labelled PR) and pass the head SHA so the bus can re-open the review thread when the head changes. Producer half of re-review-on-push, mirroring kendo and town-crier#20's template change. The resolve job is unchanged.

Inert until town-crier#20 is merged + deployed (the bus must understand head_oid first); a re-announce with the same head is a harmless no-op.

🤖 Generated with Claude Code

@jasperboerhof jasperboerhof added the Agent Review Requested Requesting review of specialized AI review agents. label Jun 22, 2026
@jasperboerhof

Copy link
Copy Markdown
Contributor Author

Town Crier Review · 9/10 · PASS · 🔎 Independent

kendo-report-tool #6 · AC anchor: PR description (no linked issue; config-only) · head 899dd64608 · via the town-crier bus (request #126)

Tip

Single-file CI-config catch-up: the announce-pr.yml producer now re-announces on synchronize and ships head_oid in the payload, bringing kendo-report-tool's copy to parity with the canonical town-crier template. Verified end-to-end against the bus contract (/announce accepts head_oid at src/index.ts:38,51; postRequest reopen semantics at src/db.ts:218-248 match the workflow's stated same-head-no-op / new-head-reopen claim), the CI-event simulation holds (no labeled/synchronize double-fire, unlabelled PRs guarded out), and the YAML parses valid with CI green.

No findings — clean against the review checklist.

@Goosterhof Goosterhof left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approve-worthy

0 blockers · 0 concerns · 0 nits · 0 praise · 0 inline

Confirm-the-pattern (light sweep). This PR's announce-pr.yml change is the same substantive diff (hunk headers offset one line from a different file preamble) as the canonical script-development/town-crier#22, which I reviewed in full — verified here by diffing the two. The canonical verdict carries over: correct producer-side change (adds synchronize re-announce gated behind the Agent Review Requested label via contains(labels), threads head_oid into the announce payload; provisioning-fail-loud and transient-fail-non-blocking preserved). CI green.

Same caveat as #22: the "a re-announce with the same head is a no-op on the bus" comment is the right design but not true yet — the bus is head-blind (keys on pr_url), so the no-op waits on the consumer-side head_oid dedup (the deferred town-crier-relay-debounce-covered-heads). Non-blocking — head_oid is correctly sent here.

Automated war-room agent review — posted because this PR carries the Agent Review Requested label.

@jasperboerhof

Copy link
Copy Markdown
Contributor Author

Town Crier Review · 8/10 · PASS · 🤝 Confirm — 🟡 1

kendo-report-tool #6 · AC anchor: PR description (town-crier parity catch-up; no board issue) · head 899dd64608 · via the town-crier bus (request #126)

Tip

Config-only PR: the announce-pr.yml producer workflow now re-announces on synchronize (gated behind the Agent Review Requested label) and threads head_oid into the /announce payload, bringing kendo-report-tool's copy to parity with the canonical town-crier template. Corroborates the prior reviews (jasper, general, Goosterhof): the operative YAML is byte-identical to the canonical examples/ template, every code-checkable claim holds at head, the event matrix has no double-fire, unlabelled PRs are guarded out, and the bus contract (same-head no-op / new-head reopen) matches end-to-end. One MINOR: the file-header doc block still describes the old "announce once" behaviour this PR supersedes.

1 finding(s) — detailed below (not anchorable to diff lines).

Bus thread · 2 prior review(s):

  • jasper (independent): Independent first look (empty thread). PASS 9/10 — no findings. Single-file CI-config catch-up: the announce-pr.yml prod
  • general (confirm): Confirm-the-pattern: the same substantive diff (hunk headers offset one line from a different file preamble) as canonica

Findings outside the diff (not inline-postable)

  • 🟡 MINOR — File-header doc block still says "tell the crier once" — contradicts the re-announce this PR ships (.github/workflows/announce-pr.yml:8)
    • Fix: Update the file-header comment block (the announce: bullet) to match the canonical template's updated prose — mention the synchronize re-announce + head_oid as the change detector.

@jasperboerhof jasperboerhof merged commit e0ca308 into main Jun 24, 2026
4 checks passed
@jasperboerhof jasperboerhof deleted the ci/town-crier-reannounce-on-push branch June 24, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Agent Review Requested Requesting review of specialized AI review agents.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants