Skip to content

ci: remove redundant town-crier announce-pr producer#13

Merged
jasperboerhof merged 1 commit into
mainfrom
ci/remove-announce-pr-producer
Jun 30, 2026
Merged

ci: remove redundant town-crier announce-pr producer#13
jasperboerhof merged 1 commit into
mainfrom
ci/remove-announce-pr-producer

Conversation

@jasperboerhof

Copy link
Copy Markdown
Contributor

What

Deletes the per-repo .github/workflows/announce-pr.yml town-crier producer workflow. This is the only change — one file deletion, 155 lines, no other files touched.

Why

Town-crier now announces PRs via its GitHub App (installed org-wide), which covers announce / resolve / consensus going forward. With the App in place, this per-repo producer is redundant: it fired a second /announce to the bus on every Agent Review Requested label + push/synchronize, so every PR/label event double-posted to the bus (the announce spam).

Removing the per-repo producer stops the duplication; the GitHub App is the single announce path from here on.

Notes

This PR intentionally does not carry the Agent Review Requested label — applying it would trigger the very double-announce this change removes. For direct user merge.

Town-crier now announces PRs via its GitHub App (installed org-wide),
which covers announce/resolve/consensus going forward. This per-repo
producer workflow fired a second /announce to the bus on every
`Agent Review Requested` label + push/synchronize, double-posting on
every PR/label event. Removing it stops the duplication.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01Rn34Ujm47YgQedoudDFiJW
@jasperboerhof jasperboerhof added the Agent Review Requested Requesting review of specialized AI review agents. label Jun 29, 2026
@jasperboerhof

Copy link
Copy Markdown
Contributor Author

Town Crier Review · 9/10 · PASS · 🔎 Independent

kendo-error-tracker #13 · AC anchor: PR description (no kendo issue) · head c51ef58949 · via the town-crier bus (request #36)

Tip

Config-only PR: a clean, complete deletion of .github/workflows/announce-pr.yml (the per-repo town-crier producer). I verified it leaves no dangling references (git grep for announce/town-crier/TOWN_CRIER over all tracked files is empty), does not strand a required status check (branch protection requires only check (8.4/8.5) from ci.yml, never the producer's jobs, so merge isn't blocked), and its resolve/consensus lifecycle is explicitly claimed superseded by the org-wide GitHub App — coherent and self-contained; the only load-bearing precondition (the App actually covering announce+resolve+consensus for this repo) is external infra asserted by the bus owner and not falsifiable from the worktree, so it's a caveat, not a finding.

No findings — clean against the review checklist.

@Goosterhof Goosterhof left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approve-worthy

0 blockers · 1 concern · 0 nits · 1 praise · 0 inline
Confirming @dispatch's review: 1 extended (the App-coverage precondition).

Pure config deletion — drops .github/workflows/announce-pr.yml (the per-repo town-crier producer) to stop the double-announce now that the org-wide GitHub App owns the announce/resolve/consensus lifecycle. I verified the deletion is complete and strands nothing.

What I confirmed independently against head c51ef58:

  • Only ci.yml + release.yml remain under .github/workflows/ — the producer is fully gone.
  • Zero dangling references: the head tree has no tracked path matching announce|town.crier|TOWN_CRIER.
  • No stranded required check — main protection requires exactly check (8.4) + check (8.5) (both from ci.yml, both passing); the producer's announce/resolve/consensus jobs were never gated, so merge isn't blocked.

This confirms @dispatch's independent PASS — same three checks, same conclusion.

The one precondition (concern, not a blocker)

The load-bearing assumption is external and not falsifiable from the diff: the GitHub App's org install must actually include kendo-error-tracker. If the App is a "selected repos" install that doesn't list this repo, removing the per-repo producer leaves this repo with zero announce path — PRs would silently never reach the bus, and there's no red check to surface it (the producer was fail-open by design). The PR body asserts the App is "installed org-wide" and you own the bus, so this is your call to make and not a finding I can dispute from the worktree — but it is the single thing worth eyeballing once (App settings → repository access) before this lands across the other 13 producer repos. Confirm coverage, then this is a clean removal.

Automated war-room agent review — posted because this PR carries the Agent Review Requested label.

@jasperboerhof jasperboerhof merged commit 781a6df into main Jun 30, 2026
2 checks passed
@jasperboerhof jasperboerhof deleted the ci/remove-announce-pr-producer branch June 30, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Agent Review Requested Requesting review of specialized AI review agents.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants