Skip to content

Add distgen check to GitHub workflow#382

Merged
phracek merged 1 commit into
masterfrom
ndavidov/distgen-check
Jun 9, 2026
Merged

Add distgen check to GitHub workflow#382
phracek merged 1 commit into
masterfrom
ndavidov/distgen-check

Conversation

@ndavidova

@ndavidova ndavidova commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds the distgen-check job to the CI workflow, which validates that all distgen-generated files are in sync with their source templates
  • This check must be merged before the distgen onboarding PR (Onboard to distgen generated sources #381) to ensure the CI pipeline validates generated sources going forward

Test plan

  • Verify the distgen-check job appears in CI and passes on this branch (no generated files exist yet, so check should be a no-op or pass)
  • Once merged, confirm the check runs on subsequent PRs

Co-Authored-By: Claude Opus 4.6 [email protected]

Summary by CodeRabbit

  • Chores
    • Updated container testing workflow with an additional verification job to enhance CI/CD pipeline validation.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@ndavidova, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 23 minutes and 31 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 091f9964-76b8-41b3-84b4-63cd35532d09

📥 Commits

Reviewing files that changed from the base of the PR and between 8044276 and 18c8c3b.

📒 Files selected for processing (1)
  • .github/workflows/container-tests.yml
📝 Walkthrough

Walkthrough

The GitHub Actions workflow adds a new distgen-check job that invokes an external reusable workflow from the sclorg/ci-actions repository, alongside the existing check-readme and container-tests jobs.

Changes

Workflow job additions

Layer / File(s) Summary
Add distgen-check workflow job
.github/workflows/container-tests.yml
A new distgen-check job is configured to reuse the external distgen-check.yml@main workflow from sclorg/ci-actions, adding a distgen validation checkpoint to the CI pipeline.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A workflow grows, a step that gleams,
Distgen checks flow through CI streams,
Two lines of trust, reused with care,
Validation duties, lightly shared!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add distgen check to GitHub workflow' accurately describes the main change: adding a distgen-check job to the GitHub Actions workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ndavidov/distgen-check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Pull Request validation

Failed

🔴 Review - Missing review from a member (1 required)

Success

🟢 CI - All checks have passed


Triggered by Workflow Run

@ndavidova ndavidova force-pushed the ndavidov/distgen-check branch from 8044276 to 18c8c3b Compare June 9, 2026 13:20

@phracek phracek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phracek phracek merged commit a36fc02 into master Jun 9, 2026
1 check passed
@phracek phracek deleted the ndavidov/distgen-check branch June 9, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants