Skip to content

switch to using uv#66

Open
keewis wants to merge 22 commits into
scientific-python:mainfrom
keewis:lock-file
Open

switch to using uv#66
keewis wants to merge 22 commits into
scientific-python:mainfrom
keewis:lock-file

Conversation

@keewis

@keewis keewis commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

We're currently pulling in unpinned versions of the dependencies (pytest and more-itertools, which each depend on other projects).

As requested in #62, this changes the action to use a lock file (uv.lock currently, could become pylock.toml in the future).

(I'll setup CI that checks the action in a bit) Edit: actually, that doesn't really work because it would have to mutate this repo, which we don't want. I have reportlog-test that I can use to trigger the action, though.

cc @Zeitsperre

@keewis

keewis commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

see https://github.com/keewis/reportlog-test/actions/runs/27984701030/job/82823258100 for a test run. I didn't have time yet to check if the lock file is actually being used (if it's not in use it might be worth replacing UV_PROJECT with UV_WORKING_DIR)

@keewis

keewis commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

should be ready now, and I can confirm that the lock file is in use (or at least, that the exact versions we have in the lock file are being installed).

@Zeitsperre Zeitsperre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't sign off here, but it looks good as far as I can tell!

Comment thread parse_logs.py.lock

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! You can probably also configure Dependabot to manage updates in this file as well: https://docs.github.com/en/code-security/reference/supply-chain-security/dependabot-options-reference#package-ecosystem-

@keewis keewis Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. I'm not sure what the tradeoffs are here, so this could also use a review (only if you're up for it, of course)

Comment thread pyproject.toml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants