test: add unit tests for Link model methods#22
Merged
sanmaxdev merged 1 commit intoJul 6, 2026
Conversation
sanmaxdev
approved these changes
Jul 6, 2026
sanmaxdev
left a comment
Owner
There was a problem hiding this comment.
Thanks for adding this. I checked the Link model coverage against the current implementation and ran the relevant checks.
Passed:
vendor/bin/pint --testphp artisan testgit diff --check origin/main...HEAD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the first unit tests for the
Linkmodel, covering all its pure-logic methods. Thetests/Unit/directory was completely empty before this PR.Methods covered:
normalizeTags(),appendParams(),isExpired(),isOverLimit(),hasDeepLinks(),deepLinkFor(), andcacheKey()— 38 tests, 44 assertionsRelated issue
Closes #19
Type of change
Checklist
vendor/bin/pint(code style passes)php artisan test(all tests pass) and added/updated tests for my changenpm run buildsucceeds (if I touched front-end assets)Notes for reviewers
No production code was modified — only
tests/Unit/LinkTest.phpwas added.Tests use
Tests\TestCaseas base class (needed for Eloquent's datetime cast resolution) but do not touch the database, noRefreshDatabase, no factories, no seeders.A follow-up PR is planned to add feature tests for click tracking edge cases (bot detection, null IP, password-protected links, etc.).