fix(@sanity/cross-dataset-duplicator): address review feedback from #974

[stipsan]

Addresses the Copilot review feedback on the merged migration PR #974 for @sanity/cross-dataset-duplicator. All 10 review comments are resolved.

Walkthrough

Demo of the duplicator UI after the fixes — corrected EXISTS tooltip copy, singular/plural button label, and a zero-asset duplication completing cleanly (no broken progress bar):

cross_dataset_duplicator_review_fixes_demo.mp4

EXISTS tooltip now reads "…with the same ID and Updated time." and statuses render via the index map:

EXISTS tooltip and statuses

Button label correctly uses the singular "1 Document" (previously this branch was unreachable):

Singular button label

Changes

src/components/Duplicator.tsx

• Index destination docs by _id so status updates are O(n) instead of O(n²).
• Fail fast when an asset download response is not ok (e.g. 401/403/404) instead of uploading the error body as the asset, and surface the message.
• Create a single merged asset document at the uploaded _id, avoiding an orphaned asset document when an SVG's _id changes on upload.
• Clone documents before remapping SVG references so objects held in React state (payload) are never mutated in place.
• Fix the duplicate button label: show counts for single-item selections and only insert "and" when both documents and assets are selected.
• Guard the progress bar against a zero-asset payload (no more NaN/Infinity transform).

src/components/StatusBadge.tsx

• Tighten the awkward EXISTS tooltip copy ("with the same ID with the same…" → "with the same ID and Updated time.").

README.md

• Fix the invalid config snippet (export default defineConfig(...)).
• Remove stale standalone-repo sections (plugin-kit dev workflow, semantic-release) and the duplicate License section.

LICENSE

• Update the copyright year to the current year.

Testing

• pnpm format, pnpm lint, pnpm build, pnpm test run all pass.
• Manually verified in the test studio (pnpm dev): ran the duplicator query, confirmed the corrected tooltip, singular/plural button label, status badges (EXISTS/OVERWRITE) computed via the index map, and a zero-asset duplication completing with no broken progress-bar rendering.
• Asset/SVG-specific paths (merged asset doc, dset clone, download res.ok) are covered by the type-checked build, lint, and tests.

A patch changeset is included.

_{To show artifacts inline, enable in settings.}

  

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
plugins-studio	Ready	Preview, Comment	Jun 18, 2026 3:47pm