feat: update @sanity/icons to v5.0.0 and update icon import paths#241
Open
ahenriksen-inferno wants to merge 15 commits into
Open
feat: update @sanity/icons to v5.0.0 and update icon import paths#241ahenriksen-inferno wants to merge 15 commits into
ahenriksen-inferno wants to merge 15 commits into
Conversation
…sationList component
…m workspace configuration
|
@ahenriksen-inferno is attempting to deploy a commit to the Sanity Sandbox Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
This PR upgrades the monorepo’s @sanity/icons dependency to v5 and updates the Studio code in @sanity/context to use the v5-required explicit per-icon import subpaths, aiming to improve compatibility and tree-shaking.
Changes:
- Bump
@sanity/iconsin the workspace catalog and lockfile to5.0.0. - Update Studio icon imports across
packages/context/src/studio/**from@sanity/iconsto@sanity/icons/<IconName>. - Split multi-icon imports into per-icon subpath imports where needed.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Updates the workspace catalog to use @sanity/icons v5. |
| pnpm-lock.yaml | Locks @sanity/icons to 5.0.0 and updates dependency snapshots. |
| packages/context/src/studio/plugin.ts | Updates ChartUpwardIcon import to the v5 explicit subpath. |
| packages/context/src/studio/insights/dashboard/TextWithInfo.tsx | Updates InfoOutlineIcon import to the v5 explicit subpath. |
| packages/context/src/studio/insights/dashboard/Table.tsx | Updates arrow icon imports to explicit per-icon subpaths. |
| packages/context/src/studio/insights/dashboard/overview/ContentGapRow.tsx | Updates ChevronRightIcon import to the v5 explicit subpath. |
| packages/context/src/studio/insights/dashboard/InsightsDashboard.tsx | Updates multiple dashboard icon imports to explicit per-icon subpaths. |
| packages/context/src/studio/insights/dashboard/ErrorBlock.tsx | Updates RetryIcon import to the v5 explicit subpath. |
| packages/context/src/studio/insights/dashboard/conversations/FilterMenu.tsx | Updates filter menu icon imports to explicit per-icon subpaths. |
| packages/context/src/studio/insights/dashboard/conversations/ConversationMessage.tsx | Updates message icon imports to explicit per-icon subpaths. |
| packages/context/src/studio/insights/dashboard/conversations/ConversationList.tsx | Updates list icon imports (FilterIcon, SearchIcon) to explicit subpaths. |
| packages/context/src/studio/insights/dashboard/conversations/ConversationDetail.tsx | Updates CloseIcon import to the v5 explicit subpath. |
| packages/context/src/studio/context-document/groq-filter-input/GroqFilterInput.tsx | Replaces the grouped icon import with explicit per-icon subpath imports. |
| packages/context/src/studio/context-document/contextSchema.ts | Updates DatabaseIcon import to the v5 explicit subpath. |
| packages/context/src/studio/context-document/context-document-input/ContextDocumentInput.tsx | Updates CopyIcon import to the v5 explicit subpath. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request upgrades the
@sanity/iconspackage from version 3 to version 5 and updates all icon imports throughout the codebase to use the new explicit import paths required by the latest version. This change ensures compatibility with the updated icon package and improves tree-shaking and bundle size by importing only the icons in use.Dependency upgrade and import updates:
@sanity/iconsfrom version 3.7.4 to 5.0.0 inpnpm-lock.yamlandpnpm-workspace.yaml, and updated dependency snapshots to reflect the new version. [1] [2] [3] [4] [5]Codebase-wide icon import changes:
@sanity/icons@5(e.g.,import {CopyIcon} from '@sanity/icons/Copy'instead ofimport {CopyIcon} from '@sanity/icons') in all relevant files withinpackages/context/src/studio. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]What to review
Validate that the imports and dependency range for
@sanity/iconsinpnpm-workspace.yamlare correct.Testing
No new testing was added. Build, typecheck, lint, and tests pass.
Related Issues
Closes #240