feat: AIGRO-4919 - Invoking allowed commands from outside the cli#1598
Draft
mwritter wants to merge 6 commits into
Draft
feat: AIGRO-4919 - Invoking allowed commands from outside the cli#1598mwritter wants to merge 6 commits into
mwritter wants to merge 6 commits into
Conversation
Contributor
📦 Bundle Stats —
|
| Metric | Value | vs main (efb5705) |
|---|---|---|
| Internal (raw) | 2.2 KB | - |
| Internal (gzip) | 838 B | - |
| Bundled (raw) | 11.20 MB | +641 B, +0.0% |
| Bundled (gzip) | 2.11 MB | +206 B, +0.0% |
| Import time | 876ms | -5ms, -0.5% |
bin:sanity
| Metric | Value | vs main (efb5705) |
|---|---|---|
| Internal (raw) | 782 B | - |
| Internal (gzip) | 423 B | - |
| Bundled (raw) | 9.90 MB | - |
| Bundled (gzip) | 1.78 MB | - |
| Import time | 2.12s | +24ms, +1.1% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — @sanity/cli-core
Compared against main (efb5705b)
| Metric | Value | vs main (efb5705) |
|---|---|---|
| Internal (raw) | 118.2 KB | +4.2 KB, +3.7% |
| Internal (gzip) | 30.3 KB | +1.1 KB, +3.9% |
| Bundled (raw) | 21.77 MB | +3.4 KB, +0.0% |
| Bundled (gzip) | 3.47 MB | +679 B, +0.0% |
| Import time | 786ms | +10ms, +1.3% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — @sanity/cli-build
Compared against main (efb5705b)
@sanity/cli-build/_internal/build
| Metric | Value | vs main (efb5705) |
|---|---|---|
| Internal (raw) | 113.2 KB | - |
| Internal (gzip) | 28.7 KB | - |
| Bundled (raw) | 17.75 MB | +1014 B, +0.0% |
| Bundled (gzip) | 3.56 MB | +430 B, +0.0% |
| Import time | 1.15s | +3ms, +0.2% |
@sanity/cli-build/_internal/env
| Metric | Value | vs main (efb5705) |
|---|---|---|
| Internal (raw) | 1.8 KB | - |
| Internal (gzip) | 644 B | - |
| Bundled (raw) | 1.31 MB | - |
| Bundled (gzip) | 333.8 KB | - |
| Import time | 128ms | -0ms, -0.0% |
@sanity/cli-build/_internal/extract
| Metric | Value | vs main (efb5705) |
|---|---|---|
| Internal (raw) | 8.6 KB | - |
| Internal (gzip) | 2.7 KB | - |
| Bundled (raw) | 155.0 KB | - |
| Bundled (gzip) | 39.5 KB | - |
| Import time | 248ms | +0ms, +0.2% |
🗺️ ./_internal/env · ./_internal/extract · @sanity/cli-build:./_internal/build treemap too large to embed · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — create-sanity
Compared against main (efb5705b)
| Metric | Value | vs main (efb5705) |
|---|---|---|
| Internal (raw) | 908 B | - |
| Internal (gzip) | 483 B | - |
| Bundled (raw) | 931 B | - |
| Bundled (gzip) | 491 B | - |
| Import time | ❌ ChildProcess denied: node | - |
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
Contributor
Coverage Delta
Comparing 14 changed files against main @ Overall Coverage
|
jonahsnider
reviewed
Jul 25, 2026
| * @throws When the input contains an unterminated quote. | ||
| * @internal | ||
| */ | ||
| export function tokenizeCliArgs(input: string): string[] { |
Member
There was a problem hiding this comment.
IMO, rather than keeping this in the CLI project, the MCP server should handle parsing the args. this keeps the bundle size smaller for the CLI
Comment on lines
+16
to
+19
| ['cors add', CorsAdd], | ||
| ['cors delete', CorsDelete], | ||
| ['cors list', CorsList], | ||
| ['projects list', ProjectsList], |
Member
There was a problem hiding this comment.
is there a way we can run commands programmatically without needing to define them all here? we want to specify the allowed commands in the MCP server, not the CLI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshots - Locally tested linking
clichanges tomellonand runningpnpm inspectfrommellon