fix(cli): move --with-token argument to be first in sanity login#1589
Open
jonahsnider wants to merge 2 commits into
Open
fix(cli): move --with-token argument to be first in sanity login#1589jonahsnider wants to merge 2 commits into
jonahsnider wants to merge 2 commits into
Conversation
Signed-off-by: Jonah Snider <[email protected]>
Contributor
📦 Bundle Stats —
|
| Metric | Value | vs main (f6fd22c) |
|---|---|---|
| Internal (raw) | 2.2 KB | - |
| Internal (gzip) | 838 B | - |
| Bundled (raw) | 11.20 MB | - |
| Bundled (gzip) | 2.11 MB | - |
| Import time | 876ms | +2ms, +0.2% |
bin:sanity
| Metric | Value | vs main (f6fd22c) |
|---|---|---|
| Internal (raw) | 782 B | - |
| Internal (gzip) | 423 B | - |
| Bundled (raw) | 9.90 MB | - |
| Bundled (gzip) | 1.78 MB | - |
| Import time | 2.11s | -3ms, -0.1% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — @sanity/cli-core
Compared against main (f6fd22cc)
| Metric | Value | vs main (f6fd22c) |
|---|---|---|
| Internal (raw) | 114.1 KB | - |
| Internal (gzip) | 29.2 KB | - |
| Bundled (raw) | 21.76 MB | - |
| Bundled (gzip) | 3.46 MB | - |
| Import time | 778ms | -8ms, -1.0% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — @sanity/cli-build
Compared against main (f6fd22cc)
@sanity/cli-build/_internal/build
| Metric | Value | vs main (f6fd22c) |
|---|---|---|
| Internal (raw) | 113.8 KB | - |
| Internal (gzip) | 28.7 KB | - |
| Bundled (raw) | 17.76 MB | - |
| Bundled (gzip) | 3.56 MB | - |
| Import time | 1.13s | +5ms, +0.4% |
@sanity/cli-build/_internal/env
| Metric | Value | vs main (f6fd22c) |
|---|---|---|
| Internal (raw) | 1.8 KB | - |
| Internal (gzip) | 644 B | - |
| Bundled (raw) | 1.31 MB | - |
| Bundled (gzip) | 333.8 KB | - |
| Import time | 123ms | +1ms, +0.5% |
@sanity/cli-build/_internal/extract
| Metric | Value | vs main (f6fd22c) |
|---|---|---|
| Internal (raw) | 8.6 KB | - |
| Internal (gzip) | 2.7 KB | - |
| Bundled (raw) | 155.0 KB | - |
| Bundled (gzip) | 39.5 KB | - |
| Import time | 244ms | -0ms, -0.2% |
🗺️ ./_internal/env · ./_internal/extract · @sanity/cli-build:./_internal/build treemap too large to embed · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — create-sanity
Compared against main (f6fd22cc)
| Metric | Value | vs main (f6fd22c) |
|---|---|---|
| Internal (raw) | 908 B | - |
| Internal (gzip) | 483 B | - |
| Bundled (raw) | 931 B | - |
| Bundled (gzip) | 491 B | - |
| Import time | ❌ ChildProcess denied: node | - |
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 71d2aa3. Configure here.
Contributor
Coverage Delta
Comparing 2 changed files against main @ Overall Coverage
|
Signed-off-by: Jonah Snider <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Presentation-only CLI help and flag ordering; login behavior is unchanged aside from tests and generated README text.
Overview
sanity loginhelp and docs now list--with-tokenfirst, so CI/token-based login is easier to spot than browser/SSO options.The login command defines
--with-tokenbefore other visible flags (with an explicit sort-objects exception), moves the stdin token example up in the examples list, andSanityHelpdisables alphabetical flag sorting forloginonly so generated USAGE/FLAGS andsanity help loginkeep that order. Other commands still use the default help flag order.Tests lock in “first visible flag” for login and login-only
flagSortOrder: 'none'; the CLI README section forsanity loginis regenerated to match.Reviewed by Cursor Bugbot for commit a5547c7. Bugbot is set up for automated code reviews on this repo. Configure here.