fix(cli-build): silence mixed async/defer warning in bundled Vite dev#1515
Draft
stipsan wants to merge 2 commits into
Draft
fix(cli-build): silence mixed async/defer warning in bundled Vite dev#1515stipsan wants to merge 2 commits into
stipsan wants to merge 2 commits into
Conversation
Vite warns when module scripts mix async and defer under experimental.bundledDev. Mark studio/app entry scripts async and add a Vite plugin that also async-aligns the react-refresh preamble so every module script stays async.
Contributor
📦 Bundle Stats —
|
| Metric | Value | vs main (bb7ea81) |
|---|---|---|
| Internal (raw) | 2.2 KB | - |
| Internal (gzip) | 838 B | - |
| Bundled (raw) | 11.16 MB | - |
| Bundled (gzip) | 2.10 MB | - |
| Import time | 866ms | -1ms, -0.1% |
bin:sanity
| Metric | Value | vs main (bb7ea81) |
|---|---|---|
| Internal (raw) | 782 B | - |
| Internal (gzip) | 423 B | - |
| Bundled (raw) | 9.87 MB | - |
| Bundled (gzip) | 1.78 MB | - |
| Import time | 2.24s | -2ms, -0.1% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — @sanity/cli-core
Compared against main (bb7ea815)
| Metric | Value | vs main (bb7ea81) |
|---|---|---|
| Internal (raw) | 108.1 KB | - |
| Internal (gzip) | 27.0 KB | - |
| Bundled (raw) | 21.72 MB | - |
| Bundled (gzip) | 3.46 MB | - |
| Import time | 775ms | +1ms, +0.2% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — @sanity/cli-build
Compared against main (bb7ea815)
@sanity/cli-build/_internal/build
| Metric | Value | vs main (bb7ea81) |
|---|---|---|
| Internal (raw) | 112.4 KB | +1.4 KB, +1.3% |
| Internal (gzip) | 28.4 KB | +465 B, +1.6% |
| Bundled (raw) | 17.94 MB | +1.3 KB, +0.0% |
| Bundled (gzip) | 3.60 MB | +482 B, +0.0% |
| Import time | 1.34s | +2ms, +0.2% |
@sanity/cli-build/_internal/env
| Metric | Value | vs main (bb7ea81) |
|---|---|---|
| Internal (raw) | 1.8 KB | - |
| Internal (gzip) | 644 B | - |
| Bundled (raw) | 1.31 MB | - |
| Bundled (gzip) | 332.9 KB | - |
| Import time | 121ms | -1ms, -1.2% |
@sanity/cli-build/_internal/extract
| Metric | Value | vs main (bb7ea81) |
|---|---|---|
| Internal (raw) | 8.6 KB | - |
| Internal (gzip) | 2.7 KB | - |
| Bundled (raw) | 151.2 KB | - |
| Bundled (gzip) | 38.3 KB | - |
| Import time | 242ms | -0ms, -0.1% |
🗺️ ./_internal/env · ./_internal/extract · @sanity/cli-build:./_internal/build treemap too large to embed · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — create-sanity
Compared against main (bb7ea815)
| Metric | Value | vs main (bb7ea81) |
|---|---|---|
| Internal (raw) | 908 B | - |
| Internal (gzip) | 483 B | - |
| Bundled (raw) | 931 B | - |
| Bundled (gzip) | 491 B | - |
| Import time | ❌ ChildProcess denied: node | - |
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
Contributor
Coverage Delta
Comparing 4 changed files against main @ Overall Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With
unstable_bundledDev: true, Vite logs:That warning came from mixing:
@vitejs/plugin-react’s non-async react-refresh preamble (injected under bundledDev)This change:
<script type="module">tagsasyncinDefaultDocument/BasicDocumenttype="module"script (including the react-refresh preamble) is markedasyncafter HTML transformsVerified locally that
sanity devwithunstable_bundledDev: trueno longer prints the warning.What to review
asyncon default studio/app documentssanityAsyncModuleScriptsPluginplacement afterviteReact()so it rewrites the react-refresh injectTesting
getViteConfigsanity devwithunstable_bundledDev: true— ready message appears without the mixed async/defer warningNotes for release
Silence Vite mixed async/defer script warning when using
unstable_bundledDev