Fix secondary app signals in spawned workers - #3180
Open
bm1016bm-svg wants to merge 2 commits into
Open
Conversation
bm1016bm-svg
marked this pull request as ready for review
July 29, 2026 05:10
Author
|
CI failures appear unrelated to this change: the worker regression suite passes locally (11/11), while the failing type check is in sanic/pages/error.py and coverage fails in the uvicorn/websockets test environment. Recent main-branch Tests/Coverage runs are also failing. I cannot rerun the workflows without repository admin permission. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
In spawn mode, the primary app received its prepared state through
passthru, but secondary apps were re-imported without their per-app mode and config. A secondary app prepared withdev=Truecould therefore start with production touchups enabled and fail to resolve built-in HTTP lifecycle signals.Validation
python -m pytest tests/worker/test_worker_serve.py tests/worker/test_startup.py -q— 19 passed, 1 skippedpython -m ruff check sanic/mixins/startup.py sanic/worker/serve.py tests/worker/test_worker_serve.pypython -m ruff format --check sanic/mixins/startup.py sanic/worker/serve.py tests/worker/test_worker_serve.pygit diff --checkFixes #3179