You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
CI note: the test matrix stopped on two pre-existing mypy errors in sanic/pages/error.py (lines 15 and 43), which are unrelated to this documentation-only change. The same errors are present in the repository's earlier test run 29780572243. The remaining matrix jobs were cancelled by fail-fast, and the coverage job then failed because no coverage.xml artifact was produced.
The focused local validation for this change remains green: 49 signal tests passed, the guide page rendered successfully, and the relevant Ruff checks passed.
CI note: this PR changes only guide/content/en/guide/advanced/signals.md. The type-check job fails in unchanged sanic/pages/error.py (lines 15 and 43), and the coverage job then fails because no coverage.xml artifact was produced. The same two checks are failing on #3177 from the same base commit (5ffc7b3), so these failures are unrelated to this documentation change.
The focused signal suite and documentation rendering listed in the PR description pass locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3176
Summary
conditionkeyword.add_signalexamples consistent with the public API.Testing
python -m pytest -q tests/test_signals.py(49 passed)guide/content/en/guide/advanced/signals.mdwith the guide Markdown rendererruff check sanic/mixins/signals.pyruff format sanic/mixins/signals.py --checkgit diff --check