Fix Node.js 24 compatibility: upgrade ssh2 transitive dep via overrides#30
Merged
Conversation
…date ftp-deploy to 2.4.7, use node24 runner
Copilot
AI
changed the title
[WIP] Fix compatibility issue with Node.js version 24
Fix Node.js 24 compatibility: upgrade ssh2 transitive dep via overrides
Jul 1, 2026
Owner
|
@copilot It's working without issues now, but there is still a warning: I assume you also have to fix the Node.js version in the file action.yml to: |
Contributor
Author
This was already included in the fix — |
sand4rt
marked this pull request as ready for review
July 3, 2026 07:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[email protected](pulled in viaftp-deploy → ssh2-sftp-client) importsisDatefrom Node.js'sutiltop-level, which was removed in Node.js 24, causingTypeError: isDate is not a functionat runtime.Changes
package.json: Addoverrides.ssh2: "^1.16.0"to force the transitive dep to v1.17.0, which switched to the correct modern API (util.types.isDate); bumpftp-deployto^2.4.7action.yml: Update runner fromnode20→node24dist/index.js: Rebuilt bundle viancc buildto include the fixedssh2codeThe breaking change in
ssh2: