Sprint_4#8
Open
sanchos357-bit wants to merge 4 commits into
Open
Conversation
irisqul
reviewed
Mar 20, 2026
| assert len(collector.get_books_genre()) == 2 | ||
|
|
||
| def test_set_book_genre_set_know_genre_book_added(self): | ||
| collector = BooksCollector() |
There was a problem hiding this comment.
Отлично: в каждом тесте создается собственный экземпляр BooksCollector, но можно лучше - перенести создание экземпляра в фикстуры в отдельный файл conftest, а не повторять это предусловие в каждом тесте
|
|
||
|
|
||
| @pytest.mark.parametrize('name', ['Я','Он','Дети завтрашнего дня','Дети завтрашнего дняПиксельпутеводитель','Компания с ограниченной ответственностью']) | ||
| def test_positive_input(name): |
There was a problem hiding this comment.
нужно исправить: почему то тест вне тестового класса и название тестового метода не дает понимания что тестируется. нужно подвинуть на 4 пробела вправо
| collector.delete_book_from_favorites('Гордость и предубеждение и зомби') | ||
|
|
||
| assert collector.get_list_of_favorites_books() == [] | ||
|
|
There was a problem hiding this comment.
Нужно исправить: отсутствуют тесты на проверку методов get_books_genre. На каждый метод должен быть отдельный тест, вне зависимости, вызывается он в других тестах или нет
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Добавлены тесты в tests.py
Добавлено описание тестов в README.md