feat: add wrap helper#5
Merged
Merged
Conversation
samuelagents
approved these changes
Jun 2, 2026
samuelagents
left a comment
Owner
There was a problem hiding this comment.
Reviewed the wrap helper implementation and added a maintainer follow-up to harden default key derivation. The wrapper now avoids silent key collisions for non-plain arguments, uses toJSON values such as Date, and rejects unsupported default-key inputs with a clear custom-key error.\n\nValidation passed locally and in CI:\n- npm test\n- npm run typecheck\n- npm run build\n- CI green on Node 18, 20, and 22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2.\n\n## Summary\n- add
OnceStore.wrap(prefix, fn, options)with preserved argument/return types\n- derive default keys from the prefix plus stable JSON of the arguments, with customkeyoverride support\n- document the wrapper API and add coverage for dedupe, custom keys, and retryable failures\n\n## Validation\n-npm test\n-npm run typecheck