fix: don't strip 'src' from filepaths#34
Draft
mdb wants to merge 1 commit into
Draft
Conversation
Beginning with its initial commit (237936d) 8 years ago, `oops` strips anything up to and including a `/src/` from filepaths in stack frames. For example, files like `go/foo/bar/src/baz/bim.go` appear as `baz/bim.go` in stack frames. In addition to being somewhat confusing and arbitrary (depending on codebase/expections), this also seemingly breaks [Datadog source code integration](https://docs.datadoghq.com/integrations/guide/source-code-integration/); Datadog is unable to use [git metadata](https://docs.datadoghq.com/integrations/guide/source-code-integration/?tab=githubsaasonprem#embed-git-information-in-your-build-artifacts) embeddd in telemetry to properly link to GitHub files. This seeks to change that. Signed-off-by: Mike Ball <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beginning with its initial commit (237936d)
8 years ago,
oopsstrips anything up to and including a/src/fromfilepaths in stack frames. For example, files like
go/foo/bar/src/baz/bim.goappear as
baz/bim.goin stack frames.In addition to being somewhat confusing and arbitrary (depending on
codebase/expections), this also seemingly breaks Datadog source code
integration;
Datadog is unable to use git metadata
embeddd in telemetry to properly link to GitHub files.
This seeks to change that.
Signed-off-by: Mike Ball [email protected]