oops: get prefixes to truncate after stripping#23
Open
ianvernon wants to merge 1 commit into
Open
Conversation
When errors are serialized, oops strips any text up to, and including `/src/`. Since this is what shows up in serialized errors, it makes sense that the truncation which is done of stack frames checks whether the file has a prefix based on the stripped file name.
ianvernon
force-pushed
the
ianvernon/prefix-check-after-stripping
branch
from
2a2bd95 to
a8cda49
Compare
evnm
approved these changes
Jul 28, 2022
Comment on lines
26
to
+27
| // filtered from stacktraces based on the set of values passed by the most recent caller of this function. | ||
| // Note that the file prefix which is evaluated against the set of prefixes provided to this function when an oops |
Contributor
There was a problem hiding this comment.
Nit: Prefer to put a newline between these lines so they're broken up into separate paragraphs in Godocs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When errors are serialized, oops strips any text up to, and including
/src/.Since this is what shows up in serialized errors, it makes sense that the
truncation which is done of stack frames checks whether the file has a prefix
based on the stripped file name.