samp(py): publish samp-crypto 1.0.0, fix broken samp-core 1.x#11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
samp-coreon PyPI (1.1.0, 1.1.1, 1.2.0) has been uninstallable, it declares a runtime dep onsamp-crypto, which was not published.samp-crypto 1.0.0for PyPI: full pyproject metadata (description, license, classifiers, URLs), README, LICENSE, abi3-py39 wheels (one wheel covers Python 3.9+), 9 cargo unit tests, 3 pytest roundtrip tests, dead#[pymodule]exports pruned (ecdh,hkdf_sha256,chacha20poly1305_*), and.github/workflows/release-py-crypto.yml(trusted publisher, matrix Linux+macOS+Windows + sdist).samp-coreto 1.2.1 withsamp-crypto==1.0.0pinned exactly, and adds.github/workflows/release-py-core.yml.Architecture
Python is the only SAMP SDK with a two-package structure. Rust (
schnorrkel), TypeScript (@polkadot/wasm-crypto), and Go (ChainSafe/go-schnorrkel) all have in-language sr25519; Python has none, so the PyO3-wrapped Rust crypto lives in a separate maturin-built package.Release sequence (post-merge)
pypiGitHub environment created.samp-crypto/v1.0.0pushed first.samp-core/v1.2.1.Test plan
cargo test --lib: 9/9 passing.maturin build --release: producessamp_crypto-1.0.0-cp39-abi3-*.whl.maturin develop: works locally.python -m pytest python/tests/ python/samp-crypto/tests/: 210/210passing.
python -m buildfor samp-core: produces sdist + universal wheel.