Add a Join() function to the lo package#899
Open
eliotttak wants to merge 2 commits into
Open
Conversation
Author
|
Fixes #351. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
I added a
Join()function to thelopackage.It takes a collection and a separator (that can be any type) and returns a string that contains
every item, separated by the specified separator.
It uses
fmtto convert list items and separator to string, and astrings.Builderto construct it.I created an example on
pkg.go.devbut because the import path is github.com/samber/lo, it will be available only if you accept the PR.I wrote various tests in ./slice_test.go. Feel free to look at them if you want to verify, I tried to cover every case where my function could bug.
Checklist before requesting a review
Conventions
(ok bool)is often better than(err error)panic(...)must be limitedlo.Must0,lo.Must1,lo.Must2, ...lo.SliceToMapvslo.SliceToMapIlo.Ternaryvslo.TernaryF