[WIP][Feature][OSF-5244] Discussions page#10
Open
samanehsan wants to merge 8 commits into
Open
Conversation
- Add "Discussions" link to project nav bar - Add route, view & template for discussions page - Initialize comment view model on the discussions page - Show all project comments by default, and filter by page Conflicts: webpack.common.config.js
Add a spinner to show when comments are loading on the discussions page and ensure that the "no comments" text does not appear before the comments load, it should only appear if there are no comments, not before they are loaded.
- Add link icon to each comment that redirects to the discussions page and shows only that comment. - Change page filters to each make a new API request, where ?filter[page]=page
If the comment level of replies is greater than 5, when a user replies they will be redirected to the discussions page showing the target comment and its replies. Also add a link after the 5th level comment that will take users to that page.
When viewing a single comment and it's replies (/discussions/comment_id/) include a link to view the full comment thread beginning from the top-level comment.
- If viewing the "All Comments" discussions page, update all of the user's comment viewed timestamps for that project. - If viewing the "Project Overview" discussions view, update the project timestamp for that user. - If viewing the "Wiki" discussions, update all wiki page timestamps for that project. Same for files.
…/osf.io into feature/discussions-page Conflicts: website/static/js/comment.js
samanehsan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.