Skip to content

test(e2e): remove e2e job and verdaccio setup after CRA/webpack template removal#1524

Merged
sabertazimi merged 1 commit into
mainfrom
chore/remove-e2e-infrastructure
Jun 5, 2026
Merged

test(e2e): remove e2e job and verdaccio setup after CRA/webpack template removal#1524
sabertazimi merged 1 commit into
mainfrom
chore/remove-e2e-infrastructure

Conversation

@sabertazimi

Copy link
Copy Markdown
Owner

Summary

CRA templates, webpack template, and custom react-scripts (@sabertazimi/react-scripts) have already been removed from the monorepo. The e2e testing infrastructure that tested those templates is now entirely obsolete.

Changes

Deleted files

  • scripts/e2e.ts — E2E test harness for CRA/webpack templates
  • scripts/verdaccio.yaml — Local npm registry config (only used by e2e)
  • scripts/npmrc — localhost registry pointer (only used by CI e2e job)

Modified files

  • package.json — Remove verdaccio devDependency (-151 packages); remove stale keywords (create-react-app, react, react-scripts)
  • .github/workflows/ci.yml — Remove entire e2e CI job; remove e2e from publish and deploy job needs
  • .gitignore — Remove verdaccio-related entries (scripts/htpasswd, scripts/storage/, storage/, .npmrc)
  • AGENTS.md — Update build scripts documentation

Test plan

  • pnpm lint passes
  • pnpm install succeeds (verdaccio and 151 transitive packages removed)

@socket-security

socket-security Bot commented Jun 5, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​types/​envinfo@​7.8.41001007180100
Added@​types/​semver@​7.7.11001007581100
Added@​types/​cross-spawn@​6.0.61001007880100
Added@​vitest/​coverage-v8@​4.1.7991007999100
Addedchokidar@​5.0.010010010081100
Added@​types/​node@​24.12.41001008196100
Addedci-info@​4.4.010010010084100

View full report

@codecov

codecov Bot commented Jun 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.58%. Comparing base (8689f08) to head (2f0879f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1524   +/-   ##
=======================================
  Coverage   93.58%   93.58%           
=======================================
  Files           5        5           
  Lines          78       78           
  Branches       13       13           
=======================================
  Hits           73       73           
  Misses          4        4           
  Partials        1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ate removal

Remove `scripts/e2e.ts`, `scripts/verdaccio.yaml`, and `scripts/npmrc`
as all CRA templates, webpack template, and custom react-scripts
have been removed from the monorepo.
Remove `verdaccio` dev dependency,
clean up `.gitignore` entries, and remove the e2e CI job from publish/deploy needs.
Also remove stale CRA-related keywords from `package.json`.
@sabertazimi
sabertazimi force-pushed the chore/remove-e2e-infrastructure branch from 4c8586e to 2f0879f Compare June 5, 2026 09:42
@sabertazimi sabertazimi changed the title chore(ci): remove e2e job and verdaccio setup after CRA/webpack template removal test(e2e): remove e2e job and verdaccio setup after CRA/webpack template removal Jun 5, 2026
@sabertazimi
sabertazimi merged commit 870b7b6 into main Jun 5, 2026
8 checks passed
@sabertazimi
sabertazimi deleted the chore/remove-e2e-infrastructure branch June 5, 2026 09:43
github-actions Bot added a commit that referenced this pull request Jun 5, 2026
…ate removal (#1524)

Remove `scripts/e2e.ts`, `scripts/verdaccio.yaml`, and `scripts/npmrc`
as all CRA templates, webpack template, and custom react-scripts
have been removed from the monorepo.
Remove `verdaccio` dev dependency,
clean up `.gitignore` entries, and remove the e2e CI job from publish/deploy needs.
Also remove stale CRA-related keywords from `package.json`. 870b7b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant