additional info fields for details tab#222
Open
pranavrd wants to merge 1 commit into
Open
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation note + one open design question
How this was validated
each branch (checkbox list, dict-with-values, textbox scalar, date&time split,
empty result).
additionalFields200).req_add_info.csv(164 requests) into local Postgres andtransformed every
req_id, asserting each field resolves to a valid shape.Data-quality finding (tracked separately)
Four
list-type fields (1.1.A, 2.1.A, 5.1.1.A, 5.2.B) have malformed rows in thedata — item ids written into
field_value, or free text on selection fields. TheLambda maps them per spec; the rows themselves are wrong. Filed as a separate
data-quality issue; not addressed in this PR by design (the Lambda should not
special-case bad data).
Open design question: value-based date&time detection can misfire
Per the issue, date&time values are detected by value pattern
(
^\d{4}-\d{2}-\d{2}T) and split into_date/_time, with an explicitinstruction not to hardcode date&time
field_ids. That works, but it keys off thevalue alone with no awareness of the field's actual type.
Real example —
4.3.3.C(PREFERRED_TUTORING_FEE, alistfield whose items areitemType: "currency"):{"4.3.3.C.1": "100", "4.3.3.C.2": "200"}.REQ-00-000-000-0204) stores2026-05-10T10:00:00Zin that currencyfield → the regex fires and it's split into
_date/_time, even though this isa fee field that should never hold a datetime.
So a value that merely looks like a datetime gets datetime treatment regardless
of field type. The offending row is arguably also bad data (a datetime in a fee
field), but it exposes the limitation.
Options:
hardcode field_ids" instruction. Treats
REQ-...0204as another bad-data row,consistent with the four fields above. No new dependencies.
_date/_timewhen the metadatamarks the field as date&time. More correct, but pulls the metadata JSON into the
Lambda — a dependency the spec didn't call for.