Graph Structure Lint Rules#10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a new
graph-structurelint category for checking whether an OKF bundle is shaped coherently, not just whether links resolve.The new rules look at local neighborhoods, cross-neighborhood bridges, hub concepts, and dense local linking patterns. The goal is to help authors keep bundles navigable and useful as they grow.
What changed
neighborhoodgraph-structure/no-excessive-bridginggraph-structure/bridging-ratiograph-structure/no-leaf-bridge-fanoutgraph-structure/require-bridge-prosegraph-structure/prefer-neighborhood-index-linkgraph-structure/no-complete-neighborhood-cliquegraph-structure/min-local-cohesiongraph-structure/declare-hubsgraph.neighborhoodsconfig support, including glob pathsWhy
Basic topology checks can tell us whether a graph is connected, but not whether it is understandable.
These rules are intended to catch patterns like ordinary concepts linking all over the bundle, concepts that only point outside their local area, overloaded bridge concepts that should be declared as hubs, and
neighborhoods where every concept links to everything else.
Testing
cargo fmt --all --checkmake ciscripts/build-npm-package.shgraph-structure/*rule descriptors