build: type the ./css subpath export (drop the @ts-expect-error)#41
Open
ryankiley wants to merge 1 commit into
Open
build: type the ./css subpath export (drop the @ts-expect-error)#41ryankiley wants to merge 1 commit into
ryankiley wants to merge 1 commit into
Conversation
A TS consumer importing the stylesheet via the subpath — import "tweakit/css"; — hit TS2307: a bare package-subpath import isn't matched by a global *.css ambient, and the ./css export had no types condition. Emit a tiny side-effect dist/tweaks.css.d.ts and give ./css a types condition so the subpath resolves with no @ts-expect-error. Packaging only; source unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while integrating tweakit into a Nuxt + vue-tsc app.
Problem
Importing the stylesheet via the subpath export —
— raised
TS2307: Cannot find module 'tweakit/css'. A bare package-subpath import isn't matched by a global*.cssambient, and the./cssexport had notypescondition, so consumers needed a@ts-expect-error.Fix (packaging only — source unchanged)
dist/tweaks.css.d.ts(export {};)../cssexport gains atypescondition pointing at it;filesships it (109 B).Verify
import "tweakit/css"now resolves cleanly under--moduleResolution bundler(what Nuxt/vue-tsc use) — no@ts-expect-error.npm test28/28; declaration present in the published tarball.