fix: skip email validation for passkey#9
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the passkey submission flow in RxSignInView to bypass form validation during passkey sign-in, and also modifies the test app’s Xcode project Swift Package reference/linkage.
Changes:
- Skip schema field validation when submitting passkey sign-in (still validate for passkey sign-up).
- Update the test Xcode project’s local Swift package reference path.
- Add additional Swift package product dependency/build file entries for RxAuthSwift/RxAuthSwiftUI in the test app target.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
test/test.xcodeproj/project.pbxproj |
Alters local Swift package reference and adds additional package product dependencies/framework link entries for the test app target. |
Sources/RxAuthSwiftUI/RxSignInView.swift |
Changes passkey submission to skip validation during sign-in (but not during sign-up). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
50
to
55
| files = ( | ||
| DF4628AB2FC6EAEC002D9562 /* RxAuthSwiftUI in Frameworks */, | ||
| DF84396E2F3C848E00461950 /* RxAuthSwiftUI in Frameworks */, | ||
| DF4628A92FC6EAEC002D9562 /* RxAuthSwift in Frameworks */, | ||
| DF84396C2F3C848E00461950 /* RxAuthSwift in Frameworks */, | ||
| ); |
Comment on lines
+109
to
+110
| DF4628A82FC6EAEC002D9562 /* RxAuthSwift */, | ||
| DF4628AA2FC6EAEC002D9562 /* RxAuthSwiftUI */, |
Comment on lines
514
to
517
| DF4628A72FC6EAEC002D9562 /* XCLocalSwiftPackageReference "../../RxAuthSwift" */ = { | ||
| isa = XCLocalSwiftPackageReference; | ||
| relativePath = ..; | ||
| relativePath = ../../RxAuthSwift; | ||
| }; |
| // For passkey sign-in, skip validation - the passkey identifies the user. | ||
| // For sign-up, we still need to validate user info fields. | ||
| if mode == .signUp { | ||
| guard validate(schema, requirePassword: false) else { return } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.