Skip to content

Fix compilation on UE 5.8#583

Open
gapspt wants to merge 1 commit into
ruyo:masterfrom
gapspt:patch-1
Open

Fix compilation on UE 5.8#583
gapspt wants to merge 1 commit into
ruyo:masterfrom
gapspt:patch-1

Conversation

@gapspt

@gapspt gapspt commented Jul 13, 2026

Copy link
Copy Markdown

Removes duplicate definitions from VrmConvertModel.cpp that also exist in VrmConvertModel_Description.cpp

Removes duplicate definitions from VrmConvertModel.cpp that also exist in VrmConvertModel_Description.cpp
Copilot AI review requested due to automatic review settings July 13, 2026 08:24

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@zuyi53

zuyi53 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Have you fix the VrmConvertModel_Description ?

@gapspt

gapspt commented Jul 14, 2026

Copy link
Copy Markdown
Author

Have you fix the VrmConvertModel_Description ?

No changes needed there. The issue was duplicate symbols when building for 5.8. The VrmConvertModel_Description is basically a duplicate of VrmConvertModel, so I had only to exclude VrmConvertModel from the compilation, except for one single function.

An alternative could be to move that function also to VrmConvertModel_Description.
Another alternative would be to keep both implementations in the same file instead of having two files.

I chose the fix that required less changes in order for the review to be easier, but feel free to structure it better as you prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants