Fix compilation on UE 5.8#583
Open
gapspt wants to merge 1 commit into
Open
Conversation
Removes duplicate definitions from VrmConvertModel.cpp that also exist in VrmConvertModel_Description.cpp
Contributor
|
Have you fix the VrmConvertModel_Description ? |
Author
No changes needed there. The issue was duplicate symbols when building for 5.8. The VrmConvertModel_Description is basically a duplicate of VrmConvertModel, so I had only to exclude VrmConvertModel from the compilation, except for one single function. An alternative could be to move that function also to VrmConvertModel_Description. I chose the fix that required less changes in order for the review to be easier, but feel free to structure it better as you prefer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes duplicate definitions from VrmConvertModel.cpp that also exist in VrmConvertModel_Description.cpp