Add fdeflate backend#548
Draft
Shnatsel wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for using fdeflate as a compression/decompression backend. It's already proven in the
pngcrate used by Chromium (among other things).The backend priority is above miniz_oxide but below zlib and zlib-rs.
This PR is basically #545 but with more effort put into it.
It still depends on two upstream PRs, so I'm marking this a draft:
Buffer sizes are a guess for now, and will need tuning. Larger sizes will likely improve performance by reducing the frequency of copying the lookback buffer, at the cost of higher memory use. These will need to be adjusted to be in line with the other backends for the total amount of memory consumed.
@fintelia FYI