Skip to content
This repository was archived by the owner on Aug 16, 2021. It is now read-only.

Make backtrace-sys optional#314

Open
vi wants to merge 1 commit into
rust-lang-deprecated:masterfrom
vi:optional_backtrace_sys
Open

Make backtrace-sys optional#314
vi wants to merge 1 commit into
rust-lang-deprecated:masterfrom
vi:optional_backtrace_sys

Conversation

@vi

@vi vi commented May 15, 2019

Copy link
Copy Markdown

Resolves #313.

@vi

vi commented May 15, 2019

Copy link
Copy Markdown
Author

For this to work reliably, libraries (but not apps) depending on failure should use default-features=false, features=["std"].

Alternative is not to include default = [..., "backtrace/default"].

There can be a separate dummy crate like failure-backtrace that just enables backtrace/default, for app developers to cargo add easily. Or users may be instructed to depend on backtrace directly to get enable backtraces in failure.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should backtrace dependency be optional?

1 participant