Skip to content

Share downloaded bitcoind path with build script#170

Open
DeepCogNeural wants to merge 1 commit into
rust-bitcoin:masterfrom
DeepCogNeural:codex/use-shared-downloaded-exe-path
Open

Share downloaded bitcoind path with build script#170
DeepCogNeural wants to merge 1 commit into
rust-bitcoin:masterfrom
DeepCogNeural:codex/use-shared-downloaded-exe-path

Conversation

@DeepCogNeural

@DeepCogNeural DeepCogNeural commented Jun 18, 2026

Copy link
Copy Markdown

Fixes #47.

Summary

  • move the downloaded bitcoind executable path construction into a small shared helper
  • use that helper from both build.rs and the public downloaded_exe_path() API
  • make the build-script existing_filename check share the Windows bitcoind.exe suffix behavior

Verification

  • cargo fmt --check
  • cargo clippy -- -D warnings
  • cargo check
  • BITCOIND_SKIP_DOWNLOAD=1 cargo check --features 26_0
  • BITCOIND_SKIP_DOWNLOAD=1 cargo test downloaded_exe_path_uses_bitcoin_layout --features 26_0
  • cargo test --no-run
  • BITCOIND_SKIP_DOWNLOAD=1 cargo test --no-run --features 26_0
  • git diff --check

@DeepCogNeural DeepCogNeural force-pushed the codex/use-shared-downloaded-exe-path branch from c086a96 to 7426ab1 Compare June 18, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use downloaded_exe_path() in build.rs for existing_filename

1 participant