ci: upload signed artifacts tarball to S3 alongside .pkg#1769
Open
ayush-panta wants to merge 1 commit into
Open
ci: upload signed artifacts tarball to S3 alongside .pkg#1769ayush-panta wants to merge 1 commit into
ayush-panta wants to merge 1 commit into
Conversation
After code signing, tar the _output directory and upload to the same S3 bucket used for .pkg installers. Also add tarball entries to the release definition trigger file so they flow through the Lambda into FinchReleaseAutomationConfig/latest.json for bundle-tool consumption. Signed-off-by: ayush-panta <[email protected]>
ayush-panta
force-pushed
the
tarball-upload
branch
from
b2cac00 to
159989e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
After step [6/12] (merge-back-signed-executables), this commit:
Tars the signed
_output/directory and uploads it to the same S3 bucket as the.pkginstaller. This makes pre-extracted artifacts available for toolbox bundling without needing to extract from.pkgon the ToD worker.Adds tarball entries to the release definition JSON that gets uploaded to the trigger bucket. This ensures the tarballs flow through the
ReleaseTriggerLambdaintoFinchReleaseAutomationConfig/latest.json, making them visible to bundle-tool.The
.pkgbuild and upload (steps 7-12) is unchanged. Both artifacts coexist in S3.Naming:
finch-${VERSION}-${ARCH}.tar.gz(e.g.,finch-v1.17.1-aarch64.tar.gz)Testing done:
tarandaws s3 cpcommands locally againstfinch-installer-privatefinch vm init+finch runfrom the extracted artifactsLicense Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.